Don't compile on install without binaries #10842
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8970
This PR is trying to revive the effort started in #9576.
We don't want to compile code if there is no viable binary when running
cargo install my-name-here
.The PR in the current form is not great. Due to the new compile filter, we show
warning: Target filter `bins` specified, but no targets matched. This is a no-op
, even when the customer did not specify--bins
.I think one the way to address this issue would to update
CompileMode::Build
toCompileMode::Build { install: bool }
, but I am not sure if that change would be welcome.