Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dupe word typos #11287

Merged
merged 1 commit into from Oct 26, 2022
Merged

Fix dupe word typos #11287

merged 1 commit into from Oct 26, 2022

Conversation

Rageking8
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 26, 2022
weihanglo
weihanglo approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Out of curious, could you share the tool you use to detect these errors?

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 26, 2022

📌 Commit 61813d9 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2022
@bors
Copy link
Collaborator

bors commented Oct 26, 2022

⌛ Testing commit 61813d9 with merge 1945b44...

@Rageking8
Copy link
Contributor Author

Thanks!

Out of curious, could you share the tool you use to detect these errors?

Haha, just plain regex ^.*[^:]//.*\b([a-z]+)\s+\1\b (case insensitive)(I used the vscode in built regex search)

Not very efficient and may miss edge cases because I am not very good at regex.

@Rageking8
Copy link
Contributor Author

I might have left out a few duplicate word occurrences in this PR since I wasn't sure if it was an actual mistake. Maybe you can look at those again and correct any remaining typos. Thanks.

@bors
Copy link
Collaborator

bors commented Oct 26, 2022

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 1945b44 to master...

@bors bors merged commit 1945b44 into rust-lang:master Oct 26, 2022
@Rageking8 Rageking8 deleted the fix-dupe-word-typos branch October 27, 2022 01:17
weihanglo added a commit to weihanglo/rust that referenced this pull request Oct 27, 2022
@weihanglo
Update cargo
4d9114f 
6 commits in 9210810d1fd7b51ae0439a0a363cc50e36963455..7e484fc1a766f56dbc95380f45719698e0c82749
2022-10-25 22:31:50 +0000 to 2022-10-27 15:20:57 +0000
- fix(publish): Block until it is in index (rust-lang/cargo#11062)
- Add Accept-Encoding request header to enable compression (rust-lang/cargo#11292)
- Update contrib docs for highfive transition (rust-lang/cargo#11294)
- Migrate from highfive to triagebot (rust-lang/cargo#11293)
- Fix dupe word typos (rust-lang/cargo#11287)
- Fix confusing error messages when using -Zsparse-registry (rust-lang/cargo#11283)
@weihanglo weihanglo mentioned this pull request Oct 27, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#103645 - weihanglo:update-cargo, r=weihanglo
82e8a9a 
Update cargo

6 commits in 9210810d1fd7b51ae0439a0a363cc50e36963455..7e484fc1a766f56dbc95380f45719698e0c82749 2022-10-25 22:31:50 +0000 to 2022-10-27 15:20:57 +0000
- fix(publish): Block until it is in index (rust-lang/cargo#11062)
- Add Accept-Encoding request header to enable compression (rust-lang/cargo#11292)
- Update contrib docs for highfive transition (rust-lang/cargo#11294)
- Migrate from highfive to triagebot (rust-lang/cargo#11293)
- Fix dupe word typos (rust-lang/cargo#11287)
- Fix confusing error messages when using -Zsparse-registry (rust-lang/cargo#11283)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 28, 2022
@matthiaskrgr
Rollup merge of rust-lang#103645 - weihanglo:update-cargo, r=weihanglo
2f00f57 
Update cargo

6 commits in 9210810d1fd7b51ae0439a0a363cc50e36963455..7e484fc1a766f56dbc95380f45719698e0c82749 2022-10-25 22:31:50 +0000 to 2022-10-27 15:20:57 +0000
- fix(publish): Block until it is in index (rust-lang/cargo#11062)
- Add Accept-Encoding request header to enable compression (rust-lang/cargo#11292)
- Update contrib docs for highfive transition (rust-lang/cargo#11294)
- Migrate from highfive to triagebot (rust-lang/cargo#11293)
- Fix dupe word typos (rust-lang/cargo#11287)
- Fix confusing error messages when using -Zsparse-registry (rust-lang/cargo#11283)
@ehuss ehuss added this to the 1.66.0 milestone Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rageking8 @rust-highfive @weihanglo @bors @ehuss