Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unsupported protocol error on old macos version #11733

Merged
merged 3 commits into from Feb 17, 2023
Merged

fix: unsupported protocol error on old macos version #11733

merged 3 commits into from Feb 17, 2023

Conversation

bebecue
Copy link
Contributor

@bebecue bebecue commented Feb 17, 2023

fix #11726

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-registries Area: registries A-sparse-registry Area: http sparse registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2023
ehuss
ehuss reviewed Feb 17, 2023
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it looks like the pipewait call needs to check for old curl too.

src/cargo/sources/registry/http_remote.rs Outdated Show resolved Hide resolved
@rustbot rustbot added the A-networking Area: networking issues, curl, etc. label Feb 17, 2023
@bebecue
Copy link
Contributor Author

bebecue commented Feb 17, 2023

Also, it looks like the pipewait call needs to check for old curl too.

added in 9e2933e

weihanglo
weihanglo approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

Would you like to submit backport as well? I could help that if that sounds a bit too boring to you.

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 17, 2023

📌 Commit 9e2933e has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2023
@bors
Copy link
Collaborator

bors commented Feb 17, 2023

⌛ Testing commit 9e2933e with merge 17b3d0d...

@bors
Copy link
Collaborator

bors commented Feb 17, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 17b3d0d to master...

@bors bors merged commit 17b3d0d into rust-lang:master Feb 17, 2023
@weihanglo weihanglo mentioned this pull request Feb 17, 2023
Merged
@bebecue bebecue mentioned this pull request Feb 18, 2023
Merged
@bebecue bebecue deleted the issue-11726 branch February 18, 2023 01:34
@bebecue
Copy link
Contributor Author

bebecue commented Feb 18, 2023

Would you like to submit backport as well? I could help that if that sounds a bit too boring to you.

Just submitted as #11735

bors added a commit that referenced this pull request Feb 18, 2023
@bors
Auto merge of #11735 - bebecue:backport-11733, r=weihanglo
3469009 
[beta-1.68] backport #11733

backport #11733
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2023
@weihanglo
Update cargo
55a7915 
10 commits in 39c13e67a5962466cc7253d41bc1099bbcb224c3..17b3d0de0897e1c6b8ca347bd39f850bb0a5b9f6
2023-02-12 02:01:08 +0000 to 2023-02-17 19:45:09 +0000

- fix: unsupported protocol error on old macos version (rust-lang/cargo#11733)
- Error on invalid alphanumeric token for crates.io (rust-lang/cargo#11600)
- Add clippy lints (rust-lang/cargo#11722)
- chore: Make dependencies alphabetical order (rust-lang/cargo#11719)
- chore: bump mdbook to 0.4.27 (rust-lang/cargo#11716)
- Amend `mdman` tests. (rust-lang/cargo#11715)
- Run CI for macOS on nightly (rust-lang/cargo#11712)
- doc: doc comments and intra-doc links for `core::compiler` (rust-lang/cargo#11711)
- Ensure em dashes are recognizable in markup (rust-lang/cargo#11646)
- Set CARGO_BIN_NAME environment variable also for binary examples (rust-lang/cargo#11705)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 18, 2023
@matthiaskrgr
Rollup merge of rust-lang#108197 - weihanglo:update-cargo, r=weihanglo
5d5e0b0 
Update cargo

10 commits in 39c13e67a5962466cc7253d41bc1099bbcb224c3..17b3d0de0897e1c6b8ca347bd39f850bb0a5b9f6 2023-02-12 02:01:08 +0000 to 2023-02-17 19:45:09 +0000

- fix: unsupported protocol error on old macos version (rust-lang/cargo#11733)
- Error on invalid alphanumeric token for crates.io (rust-lang/cargo#11600)
- Add clippy lints (rust-lang/cargo#11722)
- chore: Make dependencies alphabetical order (rust-lang/cargo#11719)
- chore: bump mdbook to 0.4.27 (rust-lang/cargo#11716)
- Amend `mdman` tests. (rust-lang/cargo#11715)
- Run CI for macOS on nightly (rust-lang/cargo#11712)
- doc: doc comments and intra-doc links for `core::compiler` (rust-lang/cargo#11711)
- Ensure em dashes are recognizable in markup (rust-lang/cargo#11646)
- Set CARGO_BIN_NAME environment variable also for binary examples (rust-lang/cargo#11705)

r? `@ghost`
weihanglo added a commit to weihanglo/rust that referenced this pull request Feb 26, 2023
@weihanglo
[beta-1.68] cargo beta backports
b6383e7 
3 commits in ddf05ad7a66f4cfbe79d7692b84aa144c1aac34d..115f34552518a2f9b96d740192addbac1271e7e6
2023-02-09 03:13:43 +0000 to 2023-02-26 15:07:29 +0000

- [beta-1.68] backport rust-lang/cargo#11756 (rust-lang/cargo#11773)
- [beta-1.68] backport rust-lang/cargo#11759 (rust-lang/cargo#11760)
- [beta-1.68] backport rust-lang/cargo#11733 (rust-lang/cargo#11735)
@weihanglo weihanglo mentioned this pull request Feb 26, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 27, 2023
@bors
Auto merge of rust-lang#108508 - weihanglo:update-beta-cargo, r=weiha…
453d6d2 
…nglo

[beta-1.68] cargo beta backports

3 commits in ddf05ad7a66f4cfbe79d7692b84aa144c1aac34d..115f34552518a2f9b96d740192addbac1271e7e6 2023-02-09 03:13:43 +0000 to 2023-02-26 15:07:29 +0000

- [beta-1.68] backport rust-lang/cargo#11756 (rust-lang/cargo#11773)
- [beta-1.68] backport rust-lang/cargo#11759 (rust-lang/cargo#11760)
- [beta-1.68] backport rust-lang/cargo#11733 (rust-lang/cargo#11735)

r? `@ghost`
@ehuss ehuss added this to the 1.69.0 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss left review comments

@weihanglo weihanglo weihanglo approved these changes

Assignees

@epage epage

Labels
A-networking Area: networking issues, curl, etc. A-registries Area: registries A-sparse-registry Area: http sparse registries S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

Unsupported protocol with sparse registry
6 participants
@bebecue @rustbot @weihanglo @bors @ehuss @epage