Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced configuration discovery for cargo install and cargo uninstall commands #11775

Closed

Conversation

jofas
Copy link
Contributor

@jofas jofas commented Feb 26, 2023

This PR orthogonalizes the behaviour concerning configuration resolution of cargo uninstall with cargo install. Namely, both should ignore local configuration and only consider $CARGO_HOME/config.toml as configuration.

This PR is draft with the following still open:

For more information see discussions in:

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation Command-uninstall S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
@jofas jofas marked this pull request as draft February 26, 2023 10:48
@rustbot rustbot added A-configuration Area: cargo config files and env vars Command-install labels Feb 28, 2023
@jofas jofas force-pushed the uninstall-configuration-discovery branch from b73b642 to cf28a67 Compare March 1, 2023 14:45
@jofas jofas changed the title cargo uninstall should ignore local configuration chain to orthogonalize its behavior with cargo install Enhanced configuration discovery for cargo install and cargo uninstall commands Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. A-cli-help Area: built-in command-line help A-configuration Area: cargo config files and env vars A-documenting-cargo-itself Area: Cargo's documentation Command-install Command-uninstall S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants