Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--help output use line wrap #11991

Closed
wants to merge 11 commits into from
Closed

Conversation

heisen-li
Copy link
Contributor

What does this PR try to resolve?

Enable the wrap_help feature to help the output of --help wrap, making it easier to read.

Fixes #11895

@rustbot
Copy link
Collaborator

rustbot commented Apr 18, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2023
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you commit the change of Cargo.lock? Thanks.

@weihanglo
Copy link
Member

Could you also squash all commits into one? Some doesn't look necessary to keep. Thank you :)

heisen-li and others added 11 commits April 21, 2023 11:06
When changing cargo versions from stable to nightly, it's possible
that the Cargo.lock format changes ever so slightly. This leaves
the `Cargo.lock` file changed which is picked up by `git status`.

This patch adjusts the `git status` invocation to limit itself
to the CWD.
This is a short-term option until we can have a better solution for
globbing.  This does not update `benches/` to support which has a README
in there preventing globbing; this seems low-churn enough not to find a
solution for it.

On the next sync-up with rust-lang/rust, we'll need to update https://github.com/rust-lang/rust/blob/4e463012580415a932ae4fc255aff45982c70369/src/bootstrap/tool.rs#L588-L603

Fixes rust-lang#11988
Adds support for LoongArch.
@rustbot rustbot added the A-registry-authentication Area: registry authentication and authorization (authn authz) label Apr 21, 2023
@heisen-li heisen-li closed this Apr 21, 2023
@heisen-li heisen-li deleted the wrap_help branch April 21, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-registry-authentication Area: registry authentication and authorization (authn authz) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--help output should use line wrapping
7 participants