Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating "features" documentation to add a note about the new limit on number of features #12913

Merged
merged 2 commits into from Nov 3, 2023

Conversation

anupj
Copy link
Contributor

@anupj anupj commented Nov 3, 2023

What does this PR try to resolve?

Adding the following note to features docs page

Note: New crates or versions published on crates.io are now limited to
a maximum of 300 features. Exceptions are granted on a case-by-case basis.
See this [blog post] for details. Participation in solution discussions is
encouraged via the crates.io Zulip stream.

How should we test and review this PR?

I don't think this change requires any additional testing beyond a general review.

Additional information

Updating docs to reflect the fact that crate features are limited to 300 to ensure system stability as per this blog post announcement:
https://blog.rust-lang.org/2023/10/26/broken-badges-and-23k-keywords.html
@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2023
@epage
Copy link
Contributor

epage commented Nov 3, 2023

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 3, 2023

📌 Commit 51bef65 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2023
@bors
Copy link
Collaborator

bors commented Nov 3, 2023

⌛ Testing commit 51bef65 with merge 0fe3257...

@bors
Copy link
Collaborator

bors commented Nov 3, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 0fe3257 to master...

@bors bors merged commit 0fe3257 into rust-lang:master Nov 3, 2023
20 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2023
Update cargo

8 commits in b4d18d4bd3db6d872892f6c87c51a02999b80802..65e297d1ec0dee1a74800efe600b8dc163bcf5db
2023-10-31 18:19:10 +0000 to 2023-11-03 20:56:31 +0000
- fix(cli): Clarify --test is for targets, not test functions (rust-lang/cargo#12915)
- Updating "features" documentation to add a note about the new limit on number of features (rust-lang/cargo#12913)
- fix: merge `trim-paths` from different profiles (rust-lang/cargo#12908)
- Add regression test for issue 6915: features and transitive dev deps (rust-lang/cargo#12907)
- chore(deps): update rust crate gix to 0.55.2 (rust-lang/cargo#12906)
- chore(deps): update compatible (rust-lang/cargo#12905)
- docs(ref): Fix open-semver-range issue link (rust-lang/cargo#12904)
- docs(ref): Highlight commands to answer dep resolution questions (rust-lang/cargo#12903)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants