Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(add): Remove inconsistent period #13446

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion src/cargo/ops/cargo_add/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1003,7 +1003,6 @@ fn print_action_msg(shell: &mut Shell, dep: &DependencyUI, section: &[String]) -
format!("{} for target `{}`", &section[2], &section[1])
};
write!(message, " {section}")?;
write!(message, ".")?;
shell.status("Adding", message)
}

Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/add_basic/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package v99999.0.0 to dependencies.
Adding my-package v99999.0.0 to dependencies
4 changes: 2 additions & 2 deletions tests/testsuite/cargo_add/add_multiple/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package1 v99999.0.0 to dependencies.
Adding my-package2 v99999.0.0 to dependencies.
Adding my-package1 v99999.0.0 to dependencies
Adding my-package2 v99999.0.0 to dependencies
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Updating `dummy-registry` index
warning: translating `linked_hash_map` to `linked-hash-map`
warning: translating `Inflector` to `inflector`
Adding linked-hash-map v0.5.4 to dependencies.
Adding linked-hash-map v0.5.4 to dependencies
Features:
- clippy
- heapsize
Expand All @@ -10,7 +10,7 @@ warning: translating `Inflector` to `inflector`
- serde
- serde_impl
- serde_test
Adding inflector v0.11.4 to dependencies.
Adding inflector v0.11.4 to dependencies
Features:
+ heavyweight
+ lazy_static
Expand Down
4 changes: 2 additions & 2 deletions tests/testsuite/cargo_add/build/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-build-package1 v99999.0.0 to build-dependencies.
Adding my-build-package2 v99999.0.0 to build-dependencies.
Adding my-build-package1 v99999.0.0 to build-dependencies
Adding my-build-package2 v99999.0.0 to build-dependencies
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding cargo-list-test-fixture-dependency (local) to build-dependencies.
Adding cargo-list-test-fixture-dependency (local) to build-dependencies
Features:
- one
- two
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/change_rename_target/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package2 v99999.0.0 to optional dependencies.
Adding my-package2 v99999.0.0 to optional dependencies
Adding feature `some-package`
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/cyclic_features/stderr.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding test_cyclic_features v0.1.1 to dependencies.
Adding test_cyclic_features v0.1.1 to dependencies
Features:
+ feature-one
+ feature-two
4 changes: 2 additions & 2 deletions tests/testsuite/cargo_add/default_features/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package1 v99999.0.0 to dependencies.
Adding my-package2 v0.4.1 to dependencies.
Adding my-package1 v99999.0.0 to dependencies
Adding my-package2 v0.4.1 to dependencies
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Adding foo (workspace) to dependencies.
Adding foo (workspace) to dependencies
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding foo (workspace) to dependencies.
Adding foo (workspace) to dependencies
Features as of v0.0.0:
+ default-base
+ default-merge-base
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Adding foo (workspace) to optional dependencies.
Adding foo (workspace) to optional dependencies
Adding feature `foo`
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Adding foo (workspace) to public dependencies.
Adding foo (workspace) to public dependencies
4 changes: 2 additions & 2 deletions tests/testsuite/cargo_add/dev/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-dev-package1 v99999.0.0 to dev-dependencies.
Adding my-dev-package2 v99999.0.0 to dev-dependencies.
Adding my-dev-package1 v99999.0.0 to dev-dependencies
Adding my-dev-package2 v99999.0.0 to dev-dependencies
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding cargo-list-test-fixture-dependency (local) to dev-dependencies.
Adding cargo-list-test-fixture-dependency (local) to dev-dependencies
Features as of v0.0.0:
- one
- two
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/dry_run/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package v99999.0.0 to dependencies.
Adding my-package v99999.0.0 to dependencies
warning: aborting add due to dry run
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/features/stderr.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
+ eyes
- ears
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
100 activated features
100 deactivated features
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
+ eyes000
+ eyes001
Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/features_empty/stderr.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
- ears
- eyes
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
+ eyes
+ nose
Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/features_preserve/stderr.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
+ eyes
- ears
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
+ eyes
+ nose
Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/features_unknown/stderr.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
error: unrecognized feature for crate your-face: noze
disabled features:
ears, eyes, mouth, nose
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Updating `dummy-registry` index
Adding my-package v99999.0.0 to dependencies.
Adding my-package v99999.0.0 to dependencies
error: unrecognized feature for crate my-package: noze
no features available for crate my-package
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/git/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating git repository `[ROOTURL]/git-package`
Adding git-package (git) to dependencies.
Adding git-package (git) to dependencies
Updating git repository `[ROOTURL]/git-package`
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/git_branch/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating git repository `[ROOTURL]/git-package`
Adding git-package (git) to dependencies.
Adding git-package (git) to dependencies
Updating git repository `[ROOTURL]/git-package`
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/git_dev/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating git repository `[ROOTURL]/git-package`
Adding git-package (git) to dev-dependencies.
Adding git-package (git) to dev-dependencies
Updating git repository `[ROOTURL]/git-package`
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/git_inferred_name/stderr.log
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Updating git repository `[ROOTURL]/git-package`
Updating git repository `[ROOTURL]/git-package`
Adding git-package (git) to dependencies.
Adding git-package (git) to dependencies
Updating git repository `[ROOTURL]/git-package`
4 changes: 2 additions & 2 deletions tests/testsuite/cargo_add/git_multiple_names/stderr.log
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Updating git repository `[ROOTURL]/git-package`
Adding my-package1 (git) to dependencies.
Adding my-package2 (git) to dependencies.
Adding my-package1 (git) to dependencies
Adding my-package2 (git) to dependencies
Updating git repository `[ROOTURL]/git-package`
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating git repository `[ROOTURL]/git-package`
Adding package-with-feature (git) to dependencies.
Adding package-with-feature (git) to dependencies
Features:
+ target_feature
Updating git repository `[ROOTURL]/git-package`
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/git_registry/stderr.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating git repository `[ROOTURL]/versioned-package`
Adding versioned-package (git) to dependencies.
Adding versioned-package (git) to dependencies
error: failed to parse manifest at `[ROOT]/case/Cargo.toml`

Caused by:
Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/git_rev/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating git repository `[ROOTURL]/git-package`
Adding git-package (git) to dependencies.
Adding git-package (git) to dependencies
Updating git repository `[ROOTURL]/git-package`
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/git_tag/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating git repository `[ROOTURL]/git-package`
Adding git-package (git) to dependencies.
Adding git-package (git) to dependencies
Updating git repository `[ROOTURL]/git-package`
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/infer_prerelease/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding prerelease_only v0.2.0-alpha.1 to dependencies.
Adding prerelease_only v0.2.0-alpha.1 to dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/invalid_path_self/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Adding cargo-list-test-fixture (local) to dependencies.
Adding cargo-list-test-fixture (local) to dependencies
error: cannot add `cargo-list-test-fixture` as a dependency to itself
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/list_features/stderr.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
- ears
- eyes
Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/list_features_path/stderr.log
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding your-face (local) to dependencies.
Adding your-face (local) to dependencies
Features:
+ mouth
+ nose
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding your-face (local) to dependencies.
Adding your-face (local) to dependencies
Features:
- eyes
- mouth
Expand Down
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/locked_changed/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package v99999.0.0 to dependencies.
Adding my-package v99999.0.0 to dependencies
error: the manifest file [ROOT]/case/Cargo.toml needs to be updated but --locked was passed to prevent this
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/locked_unchanged/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package v99999.0.0 to dependencies.
Adding my-package v99999.0.0 to dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/lockfile_updated/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package v99999.0.0 to dependencies.
Adding my-package v99999.0.0 to dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/manifest_path_package/stderr.log
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Adding cargo-list-test-fixture-dependency (local) to dependencies.
Adding cargo-list-test-fixture-dependency (local) to dependencies
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding foo (workspace) to dependencies.
Adding foo (workspace) to dependencies
Features as of v0.0.0:
+ default-base
+ default-merge-base
Expand Down
6 changes: 3 additions & 3 deletions tests/testsuite/cargo_add/namever/stderr.log
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Updating `dummy-registry` index
Adding my-package1 >=0.1.1 to dependencies.
Adding my-package2 v0.2.3 to dependencies.
Adding my-package v99999.0.0 to dependencies.
Adding my-package1 >=0.1.1 to dependencies
Adding my-package2 v0.2.3 to dependencies
Adding my-package v99999.0.0 to dependencies
4 changes: 2 additions & 2 deletions tests/testsuite/cargo_add/no_default_features/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package1 v99999.0.0 to dependencies.
Adding my-package2 v0.4.1 to dependencies.
Adding my-package1 v99999.0.0 to dependencies
Adding my-package2 v0.4.1 to dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/no_optional/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package v0.1.0 to dependencies.
Adding my-package v0.1.0 to dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/no_public/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package v0.1.0 to dependencies.
Adding my-package v0.1.0 to dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/optional/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package v0.1.0 to optional dependencies.
Adding my-package v0.1.0 to optional dependencies
Adding feature `my-package`
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package1 v99999.0.0 to dependencies.
Adding my-package2 v0.4.1 to dependencies.
Adding my-package1 v99999.0.0 to dependencies
Adding my-package2 v0.4.1 to dependencies
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package1 v99999.0.0 to dependencies.
Adding my-package2 v0.4.1 to dependencies.
Adding my-package1 v99999.0.0 to dependencies
Adding my-package2 v0.4.1 to dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/overwrite_features/stderr.log
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
+ eyes
+ nose
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Adding cargo-list-test-fixture-dependency (local) to optional dependencies.
Adding cargo-list-test-fixture-dependency (local) to optional dependencies
Adding feature `cargo-list-test-fixture-dependency`
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Adding foo (workspace) to dependencies.
Adding foo (workspace) to dependencies
Features as of v0.0.0:
+ test
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Adding foo (workspace) to dependencies.
Adding foo (workspace) to dependencies
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Adding foo (workspace) to optional dependencies.
Adding foo (workspace) to optional dependencies
Adding feature `foo`
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Updating `dummy-registry` index
Adding unrelateed-crate v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies.
Adding unrelateed-crate v99999.0.0 to dependencies
Adding your-face v99999.0.0 to dependencies
Features:
+ ears
+ eyes
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding your-face (local) to dev-dependencies.
Adding your-face (local) to dev-dependencies
Features:
+ mouth
+ nose
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/overwrite_name_noop/stderr.log
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding your-face (local) to optional dependencies.
Adding your-face (local) to optional dependencies
Features:
+ mouth
+ nose
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package1 v99999.0.0 to dependencies.
Adding my-package2 v0.4.1 to dependencies.
Adding my-package1 v99999.0.0 to dependencies
Adding my-package2 v0.4.1 to dependencies
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package1 v99999.0.0 to dependencies.
Adding my-package2 v0.4.1 to dependencies.
Adding my-package1 v99999.0.0 to dependencies
Adding my-package2 v0.4.1 to dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/overwrite_no_optional/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package v0.1.0 to dependencies.
Adding my-package v0.1.0 to dependencies
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package v0.1.0 to optional dependencies.
Adding my-package v0.1.0 to optional dependencies
Adding feature `my-package`
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/overwrite_no_public/stderr.log
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package v0.1.0 to dependencies.
Adding my-package v0.1.0 to dependencies
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package v0.1.0 to public dependencies.
Adding my-package v0.1.0 to public dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/overwrite_optional/stderr.log
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Updating `dummy-registry` index
Adding my-package v0.1.0 to optional dependencies.
Adding my-package v0.1.0 to optional dependencies
Adding feature `my-package`
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Updating `dummy-registry` index
Adding your-face v99999.0.0 to dependencies.
Adding your-face v99999.0.0 to dependencies
Features:
- ears
- eyes
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Updating `dummy-registry` index
Adding my-package1 v99999.0.0 to optional dependencies.
Adding my-package1 v99999.0.0 to optional dependencies
2 changes: 1 addition & 1 deletion tests/testsuite/cargo_add/overwrite_path_noop/stderr.log
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Adding your-face (local) to optional dependencies.
Adding your-face (local) to optional dependencies
Features:
+ mouth
+ nose
Expand Down