Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta-1.77] chore: update jobserver to 0.1.28 #13452

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Feb 16, 2024

Beta backports:

In order to make CI pass, the following PRs are also cherry-picked:

See rust-lang/rust 120515 and 120846
@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.77.0. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2024
@weihanglo
Copy link
Member Author

See also rust-lang/rust#120515 and rust-lang/rust#120846

Update tests for changes in latest nightly

There were two changes that has caused nightly tests to start failing:
* LLVM was updated, and that caused a change in the expected data layout for the target. (rust-lang/rust#120055 update to LLVM 18)
* rust-lang/rust#121049 Do not point at `#[allow(_)]` as the reason for compat lint triggering. The test was looking for the `unused_variables` note, which is no longer printed.
@epage
Copy link
Contributor

epage commented Feb 16, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 16, 2024

📌 Commit 0f90c39 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2024
bors added a commit that referenced this pull request Feb 16, 2024
[beta-1.77] chore: update jobserver to 0.1.28

Beta backports:

- #13419

In order to make CI pass, the following PRs are also cherry-picked:

- #13444
@bors
Copy link
Collaborator

bors commented Feb 16, 2024

⌛ Testing commit 0f90c39 with merge e421d30...

@bors
Copy link
Collaborator

bors commented Feb 16, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 16, 2024
estebank and others added 2 commits February 16, 2024 14:20
`rustc` will start marking the suggestions for prefacing unused bindings
with underscores as "maybe incorrect", which makes them no longer auto
applicable by `rustfix`.

Change done at rust-lang/rust#120470.
This change is necessary to allow rustc to actually start emitting the warning about the unused `mut`
@epage
Copy link
Contributor

epage commented Feb 16, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 16, 2024

📌 Commit b8f17ea has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2024
@bors
Copy link
Collaborator

bors commented Feb 16, 2024

⌛ Testing commit b8f17ea with merge 837c09f...

@bors
Copy link
Collaborator

bors commented Feb 16, 2024

☀️ Test successful - checks-actions
Approved by: epage
Pushing 837c09f to rust-1.77.0...

@bors bors merged commit 837c09f into rust-lang:rust-1.77.0 Feb 16, 2024
22 checks passed
@weihanglo weihanglo deleted the rust-1.77.0-backport branch February 16, 2024 21:59
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2024
…nglo

[beta-1.77.0] backport cargo

1 commits in c8a48facdaabe1d1fa8de11f90737801f38d8fa1..837c09f04022352c26cf445f37492709922b24ef
2024-02-07 19:15:46 +0000 to 2024-02-16 20:47:59 +0000
- [beta-1.77] chore: update jobserver to 0.1.28 (rust-lang/cargo#13452)

r? ghost
@rustbot rustbot added this to the 1.77.0 milestone Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants