fix: remove unused sysroot_host_libdir
#13468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-build-execution
weihanglo
changed the title
sysroot_host_libdirsysroot_host_libdir
Copy from <rust-lang#10469 (comment)>: > I've never been entirely clear why it does this. rust-lang#4006 didn't really > explain why it added the corresponding host_dylib_path. I can't envision > a scenario where it matters. I think compiler plugins and proc-macros > should load just fine, since libstd.so should already be loaded by the > compiler. Also, rustc uses rpath these days, and on Windows libstd.so is > placed in the bin directory which will be searched first anyways. > > On balance, I think it should be safe to just remove sysroot_host_libdir. > I can't come up with a scenario where it matters, at least on > windows/macos/linux. One issue is that this is most likely to affect > plugins, but those are deprecated and I think only Servo was the real > holdout. A concern is that nobody is going to test this use case before > it hits stable. Also, * compiler plugins were removed rust-lang/rust#116412 * servo has moved off from plugins: servo/servo#30508 So should generally be fine.
weihanglo
force-pushed
the
remove-host-libdir
branch
from
1f32908
to
4402b5c
Compare
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Update cargo 9 commits in 7b7af3077bff8d60b7f124189bc9de227d3063a9..194a60b2952bd5d12ba15dd2577a97eed7d3c587 2024-02-17 14:13:00 +0000 to 2024-02-21 01:53:45 +0000 - fix: remove unused `sysroot_host_libdir` (rust-lang/cargo#13468) - feat: support `target.<triple>.rustdocflags` officially (rust-lang/cargo#13197) - Fix unused imports on Windows. (rust-lang/cargo#13469) - Fix more redundant imports. (rust-lang/cargo#13466) - test: Remove empty snapshots (rust-lang/cargo#13465) - chore: Rename `Config` to `GlobalContext` (rust-lang/cargo#13409) - Fix redundant imports. (rust-lang/cargo#13464) - feat: respect `rust-version` when generating lockfile (rust-lang/cargo#12861) - chore(ci): bump CI tools (rust-lang/cargo#13459) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Copy from #10469 (comment):
Also,
So should generally be fine.
How should we test and review this PR?
There might be some edge case like #7798 passing
--sysroot, though I would also expect rustc to load sysroot from provided path. Hence safe?Additional information