Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toml): Warn on unused workspace.dependencies keys on virtual workspaces #13664

Merged
merged 12 commits into from
Mar 28, 2024
Merged

fix(toml): Warn on unused workspace.dependencies keys on virtual workspaces #13664

merged 12 commits into from
Mar 28, 2024

Commits on Mar 25, 2024

  1. refactor(toml): Remove a variable that doesnt need tracking

    @epage
    epage committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e30ddc4 View commit details
    Browse the repository at this point in the history

  2. refactor(toml): Group workspace inheritance logic

    @epage
    epage committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    dd8f8dc View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. refactor(toml): Group workspace inheritance functions

    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    b63e385 View commit details
    Browse the repository at this point in the history

  2. refactor(toml): Consistently don't include pkgid 

    This is the only error we do this for and we have the context for what
manifest we are parsing.
By removing this, it makes it easier to adjust lifetimes in the short
term.
    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    386c4b6 View commit details
    Browse the repository at this point in the history

  3. refactor(toml): Delay pkgid/summary creation

    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3b7fddb View commit details
    Browse the repository at this point in the history

  4. refactor(toml): Pull out the dep resolve/validate code

    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1855a4a View commit details
    Browse the repository at this point in the history

  5. refactor(toml): Decouple Dep and TomlDep creation

    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    e4f1eb0 View commit details
    Browse the repository at this point in the history

  6. refactor(toml): Consolidate public nightly check with clearing it

    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5d2fa44 View commit details
    Browse the repository at this point in the history

  7. fix(toml): Warn on unused workspace.dependencies keys on virtual work… 

    …spaces
    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    573fe52 View commit details
    Browse the repository at this point in the history

  8. refator(tom): Give up and allow warnings anywhere

    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9312590 View commit details
    Browse the repository at this point in the history

  9. refactor(toml): Centralize workspace config processing

    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    453f39f View commit details
    Browse the repository at this point in the history

  10. refactor(toml): Consolidate workspace dependency verification

    @epage
    epage committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8a82df2 View commit details
    Browse the repository at this point in the history