Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command run-custom-build. #13676

Closed
wants to merge 1 commit into from

Conversation

declantsien
Copy link

Add command run-custom-build for just run Cargo's build script.
See some context from #7178.

I left the doc/man changes for now.
Post the PR here hoping to receiving some feedback.

@rustbot
Copy link
Collaborator

rustbot commented Apr 1, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @weihanglo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-cargo-targets Area: selection and definition of targets (lib, bins, examples, tests, benches) A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2024
@ehuss
Copy link
Contributor

ehuss commented Apr 1, 2024

Thanks for the PR! Considering that RFC 3344 has not yet been accepted, it may be premature to open a PR for the implementation. If there is some feedback you'd like to leave on the RFC, it would be helpful to leave a comment over there.

@declantsien
Copy link
Author

Thanks for the PR! Considering that RFC 3344 has not yet been accepted,

Right, looking forward to that rfc.

Until then, I am working on this cargo-ninja. Generating build.ninja using data from Cargo build-plan.

Made it work for just run run-custom-build target for my project. So it's OK to wait a bit longer.

@epage
Copy link
Contributor

epage commented Apr 1, 2024

Closing until we have an agreed-to-design.

@epage epage closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cargo-targets Area: selection and definition of targets (lib, bins, examples, tests, benches) A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants