Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toml): Warn, rather than fail publish, if a target is excluded #13713

Merged
merged 6 commits into from
Apr 29, 2024
Merged

fix(toml): Warn, rather than fail publish, if a target is excluded #13713

merged 6 commits into from
Apr 29, 2024

Commits on Apr 29, 2024

  1. test(package): Show current case behavior

    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    340050e View commit details
    Browse the repository at this point in the history

  2. test(package): Show different crate discovery cases 

    I left off the explicit `path` cases because I hope that will become
moot
    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0cf29c5 View commit details
    Browse the repository at this point in the history

  3. perf(toml): Avoid looking up readme on published packages 

    Not much of a performance gain;
this is mostly done to be consistent with the target work.
    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    39f1a21 View commit details
    Browse the repository at this point in the history

  4. fix(toml): Warn, rather than fail publish, if build.rs is excluded 

    This could offer a minor performance gain when reading this manifest
since the target doesn't need to be discovered.
    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    1e60477 View commit details
    Browse the repository at this point in the history

  5. fix(toml): Warn, rather than fail publish, if targets are excluded 

    This could offer performance gains when parsing a published
manifest since the targets don't need to be discovered.
To see this, we'd first need to stop discovering potential targets even when it isn't
needed.
    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    06a5714 View commit details
    Browse the repository at this point in the history

  6. docs(toml): Clarify what resolving a TOML means

    @epage
    epage committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    8cc2f39 View commit details
    Browse the repository at this point in the history