Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc]: Add create workspace doc #13766

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

heisen-li
Copy link
Contributor

What does this PR try to resolve?

The second part of #13580.

There was a discussion in the previous issue and it looks like there are preliminary results?

Reference:
#13580 (comment)
#13580 (comment)

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2024
src/doc/src/SUMMARY.md Outdated Show resolved Hide resolved
@heisen-li heisen-li marked this pull request as ready for review April 18, 2024 12:33
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just skimmed through. Some minor suggestions added.

src/doc/src/guide/creating-a-new-workspace.md Outdated Show resolved Hide resolved
src/doc/src/guide/creating-a-new-workspace.md Outdated Show resolved Hide resolved
src/doc/src/guide/creating-a-new-workspace.md Outdated Show resolved Hide resolved
src/doc/src/guide/creating-a-new-workspace.md Outdated Show resolved Hide resolved
src/doc/src/guide/creating-a-new-workspace.md Outdated Show resolved Hide resolved
src/doc/src/guide/creating-a-new-workspace.md Outdated Show resolved Hide resolved
src/doc/src/guide/creating-a-new-workspace.md Outdated Show resolved Hide resolved
src/doc/src/guide/creating-a-new-workspace.md Outdated Show resolved Hide resolved
Comment on lines 9 to 11
- The crate namespace at the Cargo level is flat. The tree layout creates another hierarchy and increases the possibility of inconsistencies.
- With a flat structure, adding or splitting crates is very easy.
- Even larger flattened lists are easier to see at a glance and easier to maintain than smaller tree structures.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like its blurring the line between a guide-level document and the best practices examples that would hang off the reference.

Seeing this proposed document, I feel like its not pulling enough weight and I wonder if we should first focus in that examples / practices document

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you mean that if add this section it might become a best practice type of article rather than an instructional one. Then I have adjusted the article to make it more suitable as an instructional article for newbies.

heisen-li and others added 5 commits April 19, 2024 11:31
Co-authored-by: Weihang Lo <weihanglo@users.noreply.github.com>
…space_example

* 'master' of https://github.com/rust-lang/cargo: (28 commits)
  fix(toml)!: Disallow source-less dependencies
  fix(credential): trim newlines in token from stdin for credential providers
  fix(schemas): Allow parsing pre-release with X
  test(schemas): Add PartialVersion unit tests
  test(msrv): Migrate most parse tests to unit tests
  fix(msrv): Error, rather than panic, on rust-version 'x'
  test(msrv): Show current parse behavior with X
  show buggy behavior of not trimming newlines in new credential process test
  fix(msrv): Put MSRV-aware resolver behind a config
  test(msrv): Show config on stable
  test(msrv): Prep for config to be added
  test(resolver): Verify some more msrv cases
  test(msrv): Reorganize MSRV tests
  test(msrv): Show regular MSRV resolve case
  test(msrv): Group bad rust-version tests
  feat(install): Including Locking message
  refactor(resolve): Make it easier to customize around the resolve call
  docs: Clarify why we aren't printing Locking in some cases
  feat(fix): Migrate from project to package on Edition 2024
  feat(fix): Report manifest migrations
  ...
…into workspace_example

* 'workspace_example' of https://github.com/heisen-li/cargo:
  Use specific technical terms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants