New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename --out-dir to --artifact-dir #13809
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Grim news. Perhaps both flags must be briefly supported to deal with the bootstrap problem. |
Currently this breaks the build because some Cargo scripts seem to use a version of cargo that somehow recognizes out-dir instead of artifact-dir
Never mind; it seems I was a bit zealous in replacing |
2de8e22
to
549b724
Compare
This should be ready for review now. Not sure if this needs to go through any sort of design process since it's renaming a nightly-only API. There does seem to be some consensus in #6790 that |
Progress towards unblocking #6790. Renames the experimental
--out-dir
argument to--artifact-dir
, both to reflect that it's where the final build artifacts will be copied to, and to avoid confusion with theOUT_DIR
environment variable which serves an entirely different purpose.Existing users of the
--out-dir
argument andout-dir
config.toml key will be redirected to--artifact-dir
via a warning message.Rationale
A lot of people seem to be confused by the naming of the
--out-dir
argument, and are misled into thinking it serves the same purpose as theOUT_DIR
environment variable: