[beta-1.79] fix(config): Ensure --config net.git-fetch-with-cli=true is respected
#13997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f525e1f. This removes color control from warnings for unstable features. For some reason this removed color support from `cargo -Zhelp` in the tests but I can't reproduce it locally. The most important thing was getting the config fix in. There are two follow ups - Can we have the config working *and* color? - Why did this fail for this field and not the others we already had tests for? I ran out my immediate time box for looking into these. Fixes rust-lang#13991
|
rustbot
added
A-configuration
weihanglo
approved these changes
Jun 1, 2024
|
Maybe this is needed? #13964 |
As lint dropping_copy_types will give suggsetion in this situation.(Changed in rust-lang/rust#125433)
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2024
…nglo [beta-1.79] Update cargo 1 commits in 9ca20fadf04af535ec39d1e18c87cd886185d300..ffa9cf99a594e59032757403d4c780b46dc2c43a 2024-05-22 17:55:16 +0000 to 2024-06-03 14:41:30 +0000 - [beta-1.79] fix(config): Ensure `--config net.git-fetch-with-cli=true` is respected (rust-lang/cargo#13997) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backports
--config net.git-fetch-with-cli=trueis respected #13992In order to make CI pass, the following PRs are also cherry-picked:
droptolet _due to nightly rustc change #13964