Update to Rust master: Update process_builder to use the new Command builder API. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Rust commit 046062d.
ghost
mentioned this pull request
Closed
|
Closing, this was done in the meantime, but thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process::configureis gone as of rust-lang/rust@046062dUpdate process_builder to use the new Command builder API.
All tests pass on Ubuntu 14.04 with the most recent Rust master
All tests except cargo_compile_with_invalid_code pass on Mac OS X 10.9 with the most recent Rust master. I believe the failure is unrelated to these changes. It is caused by the test creating the expected value from the directory from
os::tmpdir()which is a directory in/var/foldersand the spawnedcargo-compileprocess having a CWD in/private/var/folders. On Mac OS X/varis symlinked to/private/var. Because of this the error output fromrustcuses/private/var/foldersand the expected output uses/var/folders. I wrote a minimal test case outside of cargo that demonstrates this behavior: https://gist.github.com/zvms/78c24f2eebf07ec2b51f. This is resolved by #15.