Be sure to include dev-deps for doctests with --extern #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the "add immediate deps" logic bailed out too soon and didn't pick up all dev-dependencies. Closes rust-lang#1474
|
r? @wycats (rust_highfive has picked a reviewer for you, use r? to override) |
|
The whitespace only diff is quite pleasant on this one! |
|
@bors r+ |
|
📌 Commit 17ffbf8 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 7, 2015
Previously the "add immediate deps" logic bailed out too soon and didn't pick up all dev-dependencies. Closes #1474
|
☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the "add immediate deps" logic bailed out too soon and didn't pick up
all dev-dependencies.
Closes #1474