Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only doctest rlibs #1501

Merged
merged 1 commit into from
Apr 10, 2015
Merged

Only doctest rlibs #1501

merged 1 commit into from
Apr 10, 2015

Conversation

alexcrichton
Copy link
Member

This commit fixes two problems in Cargo:

  1. Only libraries targets that produce an rlib can be doc tested
  2. Only the rlib output can be doc tested

The rationale for this is listed in listed in the comments of the commit.

Closes #1496

@rust-highfive
Copy link

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw
Copy link
Member

huonw commented Apr 9, 2015

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 9, 2015

📌 Commit 8e3d4cd has been approved by huonw

@bors
Copy link
Collaborator

bors commented Apr 9, 2015

⌛ Testing commit 8e3d4cd with merge 5e6142c...

@bors
Copy link
Collaborator

bors commented Apr 9, 2015

💔 Test failed - cargo-mac-64

@alexcrichton
Copy link
Member Author

@bors: r=huonw

@bors
Copy link
Collaborator

bors commented Apr 9, 2015

📌 Commit e356b3a has been approved by huonw

@bors
Copy link
Collaborator

bors commented Apr 9, 2015

⌛ Testing commit e356b3a with merge 7769b75...

@bors
Copy link
Collaborator

bors commented Apr 9, 2015

💔 Test failed - cargo-linux-64

@alexcrichton
Copy link
Member Author

@bors: r=huonw 0b8d510

@bors
Copy link
Collaborator

bors commented Apr 10, 2015

⌛ Testing commit 0b8d510 with merge e475e14...

This commit fixes two problems in Cargo:

1. Only libraries targets that produce an rlib can be doc tested
2. Only the rlib output can be doc tested

The rationale for this is listed in listed in the comments of the commit.

Closes rust-lang#1496
@alexcrichton
Copy link
Member Author

@bors: r=huonw 648eef4

@alexcrichton
Copy link
Member Author

@bors: r=huonw b1076e7

@bors
Copy link
Collaborator

bors commented Apr 10, 2015

⌛ Testing commit b1076e7 with merge 72c2e3d...

bors added a commit that referenced this pull request Apr 10, 2015
This commit fixes two problems in Cargo:

1. Only libraries targets that produce an rlib can be doc tested
2. Only the rlib output can be doc tested

The rationale for this is listed in listed in the comments of the commit.

Closes #1496
@bors
Copy link
Collaborator

bors commented Apr 10, 2015

💔 Test failed - cargo-win-32

@alexcrichton
Copy link
Member Author

@bors: retry

On Fri, Apr 10, 2015 at 11:00 AM, bors notifications@github.com wrote:

[image: 💔] Test failed - cargo-win-32
http://buildbot.rust-lang.org/builders/cargo-win-32/builds/958


Reply to this email directly or view it on GitHub
#1501 (comment).

@bors
Copy link
Collaborator

bors commented Apr 10, 2015

⚡ Previous build results for cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-64 are reusable. Rebuilding only cargo-win-32...

@bors
Copy link
Collaborator

bors commented Apr 10, 2015

☀️ Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64

@bors bors merged commit b1076e7 into rust-lang:master Apr 10, 2015
@alexcrichton alexcrichton deleted the issue-1496 branch April 30, 2015 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo test prefers dylib over rlib in doc-tests
4 participants