Remove CommandType struct #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Ah, looks like it's simpler just to store that dylib path in compilation to avoid passing it around. |
matklad
commented
Oct 13, 2016
| @@ -33,6 +33,10 @@ pub struct Compilation<'cfg> { | |||
| /// Output directory for rust dependencies | |||
| pub deps_output: PathBuf, | |||
|
|
|||
| /// Library search path for compiler plugins and build scripts | |||
| /// which have dynamic dependencies. | |||
| pub plugins_dylib_path: PathBuf, | |||
There was a problem hiding this comment.
The name's not really exciting :(
|
@bors: r+ Thanks! |
|
📌 Commit 7165bd5 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 13, 2016
Remove CommandType struct This removes `CommandType` struct as well as `cargo_rustc::process` function. So now all process creation goes thorough methods of `Compilation`. This does change search path order from `util::dylib_path(), host_dylib_path()` to `host_dylib_path(), util::dylib_path()`, but I hope this is not a problem. This also uncovers the fact that `rustdoc` is run sometimes with and sometimes without `host_dylib_path`. Is this intentional?
|
☀️ Test successful - cargo-cross-linux, cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-gnu-32, cargo-win-gnu-64, cargo-win-msvc-32, cargo-win-msvc-64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
CommandTypestruct as well ascargo_rustc::processfunction. So now all process creation goes thorough methods ofCompilation.This does change search path order from
util::dylib_path(), host_dylib_path()tohost_dylib_path(), util::dylib_path(), but I hope this is not a problem.This also uncovers the fact that
rustdocis run sometimes with and sometimes withouthost_dylib_path. Is this intentional?