Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document build badge for Gitlab CI #3632

Merged
merged 1 commit into from Feb 6, 2017
Merged

Conversation

Susurrus
Copy link
Contributor

@Susurrus Susurrus commented Feb 2, 2017

This doesn't make sense to merge until rust-lang/crates.io#539 is merged, but I figured I'd get it all spooled up since that PR is already ready for merging.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Looks good to me! I'll hold off until we merge rust-lang/crates.io#539 though

@carols10cents
Copy link
Member

@alexcrichton I just merged rust-lang/crates.io#539, so this should be good to go now :)

@alexcrichton
Copy link
Member

Thanks for the ping @carols10cents!

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 5, 2017

📌 Commit f49c883 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Feb 5, 2017

⌛ Testing commit f49c883 with merge 4ce099b...

bors added a commit that referenced this pull request Feb 5, 2017
Document build badge for Gitlab CI

This doesn't make sense to merge until rust-lang/crates.io#539 is merged, but I figured I'd get it all spooled up since that PR is already ready for merging.
@bors
Copy link
Collaborator

bors commented Feb 6, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 4ce099b to master...

@bors bors merged commit f49c883 into rust-lang:master Feb 6, 2017
@ehuss ehuss added this to the 1.17.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants