Fix rust-lang/rust 40955 #3898
Fix rust-lang/rust 40955 #3898
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| } | ||
|
|
||
| // here we have multiple bins, so they are expected to be located inside src/bin | ||
| Path::new("src").join("bin").join(&format!("{}.rs", bin.name())).to_path_buf() |
There was a problem hiding this comment.
@alexcrichton not sure about this, maybe we should support multiple bin targets (for example: foo and bar) in src/foo.rs and src.bar.rs... but what should we do with src/main.rs?
There was a problem hiding this comment.
Ah so the intention was that if you have multiple binaries they're all in src/bin/*.rs and if you have one binary it has a few possible locations it could be at, but only one or the other. We didn't intend to support src/main.rs as well as src/bin/*.rs (at least not with automatic inference).
In that sense this looks good to me, thanks!
|
Looks great, thanks for tracking this down @jmatraszek! Looks like there may be a tidy error, but otherwise did you want to add some more tests? I'm ok either way. |
|
Hi @alexcrichton, I do not suspect any error right now, just wanted to increase the test coverage for all the cases. |
|
No worries @jmatraszek! I'll fix up the tidy error and r+ this. Thanks so much for taking time to investigate this though! Feel free to let me know in the future if you're too busy, it's totally ok to punt it back to me :) |
|
@bors: r+ |
|
📌 Commit 2c9184d has been approved by |
Fix rust-lang/rust 40955 Proposed fix for rust-lang/rust#40955. I could also work on adding some additional tests, so we have all cases covered and automatically tested.
|
☀️ Test successful - status-appveyor, status-travis |
Brings in a fix for rust-lang#40955 through rust-lang/cargo#3898. Closes rust-lang#40955
Update cargo submodules Brings in a fix for rust-lang#40955 through rust-lang/cargo#3898. Closes rust-lang#40955
Update cargo submodules Brings in a fix for rust-lang#40955 through rust-lang/cargo#3898. Closes rust-lang#40955
Update cargo submodules Brings in a fix for rust-lang#40955 through rust-lang/cargo#3898. Closes rust-lang#40955
Proposed fix for rust-lang/rust#40955.
I could also work on adding some additional tests, so we have all cases covered and automatically tested.