Update dependencies #4530
Update dependencies #4530
Conversation
It would be nice to use openssl-0.9.19 in particular, since it supports newer LibreSSL.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
LGTM, but let's ask @alexcrichton about backporting. |
|
Wow, impressively speedy response, especially for a Saturday morning! 👍 |
|
@bors: r+ Sure, looks great! @djc unfortunately though I've been meaning to remove this lock file for some time as it's not actually used in the Cargo that we ship with rust-lang/rust. You'll need to send a PR to rust-lang/rust to update that lock file to ensure that Cargo's deps are updated there. I sent a PR yesterday to update some deps on the master branch, but if you've got something you'd like to land on beta and/or backport feel free to just send a PR to the beta branch! |
|
📌 Commit ab724fc has been approved by |
Update dependencies It would be nice to use openssl-0.9.19 in particular, since it supports newer LibreSSL. Not sure how this usually works, would it be better to only update openssl and related dependencies? I figured doing everything at once couldn't hurt, and it seems to pass tests locally at least. Also, would it be feasible to backport this to the beta branch?
|
☀️ Test successful - status-appveyor, status-travis |
It would be nice to use openssl-0.9.19 in particular, since it supports
newer LibreSSL.
Not sure how this usually works, would it be better to only update openssl and related dependencies? I figured doing everything at once couldn't hurt, and it seems to pass tests locally at least.
Also, would it be feasible to backport this to the beta branch?