Fix updating submodules past failures #4837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
Closed
alexcrichton
force-pushed
the
failed-submodule-checkout
branch
from
995ef97
to
08081a7
Compare
|
@bors r+ |
|
📌 Commit 08081a7 has been approved by |
|
⌛ Testing commit 08081a781a3dbe9951c38c4282c036b509d4a1a2 with merge dceb8c410ab01bfc6bb6cd4ce31d1446f77889d1... |
|
💔 Test failed - status-appveyor |
alexcrichton
force-pushed
the
failed-submodule-checkout
branch
from
08081a7
to
6b48d70
Compare
|
@bors: r=matklad |
|
📌 Commit 6b48d70 has been approved by |
|
⌛ Testing commit 6b48d70daa35d6b0cbad8ceaccecc707e3ecadfa with merge 5c88a361c11bd44c24e8b21a7e3d7f86924d4332... |
|
💔 Test failed - status-travis |
If a submodule-of-a-submodule failed to update then Cargo the next time around wouldn't automatically retry updating the next submodule. This commit fixes that by ensuring that if a parent git repository looks updated we still recurse into its own submodules to ensure they're all updated. cc rust-lang#4071
alexcrichton
force-pushed
the
failed-submodule-checkout
branch
from
6b48d70
to
ddc74a5
Compare
|
@bors: r=matklad |
|
📌 Commit ddc74a5 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 20, 2017
Fix updating submodules past failures If a submodule-of-a-submodule failed to update then Cargo the next time around wouldn't automatically retry updating the next submodule. This commit fixes that by ensuring that if a parent git repository looks updated we still recurse into its own submodules to ensure they're all updated. cc #4071
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a submodule-of-a-submodule failed to update then Cargo the next time
around wouldn't automatically retry updating the next submodule. This commit
fixes that by ensuring that if a parent git repository looks updated we still
recurse into its own submodules to ensure they're all updated.
cc #4071