Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] warn about TLS for github specifically #5086

Merged
merged 1 commit into from Feb 26, 2018

Conversation

matklad
Copy link
Member

@matklad matklad commented Feb 26, 2018

Backport of #5069 to stable for 1.24.1 🔥 ⚠️

r? @alexcrichton

@rust-highfive
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.24.0. Please double check that you specified the right target!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 26, 2018

📌 Commit 2dfa4ce has been approved by alexcrichton

@matklad
Copy link
Member Author

matklad commented Feb 26, 2018

For posterity: I've realized that I haven't done the backport in the most obvious manner: the original PR had two commits; for backport, I've cherry-picked only the last one (b/c I've forgotten that there were two commits), and had to fix (mysterious to me) merge conflicts, which amounted to basically applying the first commit as well.

So, the backport commit is basically the original two commits squashed.

@bors
Copy link
Collaborator

bors commented Feb 26, 2018

⌛ Testing commit 2dfa4ce with merge 96d8071...

bors added a commit that referenced this pull request Feb 26, 2018
[stable] warn about TLS for github specifically

Backport of #5069 to stable for 1.24.1 🔥 ⚠️

r? @alexcrichton
@bors
Copy link
Collaborator

bors commented Feb 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 96d8071 to rust-1.24.0...

@bors bors merged commit 2dfa4ce into rust-lang:rust-1.24.0 Feb 26, 2018
@matklad matklad deleted the rust-1.24.0-tls branch March 17, 2018 08:39
@ehuss ehuss added this to the 1.24.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants