[beta] Partially revert dep changes in #5651 #5722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some logic which was tweaked around the dependencies of build script targets was tweaked slightly in a way that causes cargo to stack overflow by accientally adding a dependency loop. This commit implements one of the strategies discussed in rust-lang#5711 to fix this situation. The problem here is that when calculating the deps of a build script we need the build scripts of *other* packages, but the exact profile is somewhat difficult to guess at the moment we're generating our build script unit. To solve this the dependencies towards other build scripts' executions is added in a different pass after all other units have been assembled. At this point we should know for sure that all build script executions are in the dependency graph, and we just need to add a few more edges. Closes rust-lang#5708
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
@bors: r+ |
|
📌 Commit bb9ff3d has been approved by |
|
⌛ Testing commit bb9ff3d with merge fed584a620ed88eb7fb09434fcbe371f73e8e2b4... |
|
💔 Test failed - status-travis |
|
@bors: retry |
|
☀️ Test successful - status-appveyor, status-travis |
ehuss
added a commit
to ehuss/rust
that referenced
this pull request
Jul 18, 2018
- [beta] Partially revert dep changes in rust-lang/cargo#5651 (rust-lang/cargo#5722)
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Jul 19, 2018
[BETA] Update cargo - [beta] Partially revert dep changes in rust-lang/cargo#5651 (rust-lang/cargo#5722)
moshg
pushed a commit
to moshg/rust-std-ja
that referenced
this pull request
Apr 4, 2020
- [beta] Partially revert dep changes in rust-lang/cargo#5651 (rust-lang/cargo#5722)
moshg
pushed a commit
to moshg/rust-std-ja
that referenced
this pull request
Apr 4, 2020
[BETA] Update cargo - [beta] Partially revert dep changes in rust-lang/cargo#5651 (rust-lang/cargo#5722)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a beta backport of #5711