Remove the remove TODO on Compilation.native_dirs #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @matklad (rust_highfive has picked a reviewer for you, use r? to override) |
|
Hm it looks like there's travis failure? |
|
☔ The latest upstream changes (presumably #6193) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors: delegate+ |
|
✌️ @dwijnand can now approve this pull request |
|
Is |
|
No, there's another usage. |
dwijnand
force-pushed
the
todo-remove-Compilation.native_dirs
branch
from
87d4afc
to
ab1bd24
Compare
|
The test failures are legitimate. How do we remove |
|
Ah we may just not be able to remove it at this time (as it seems to have lingering usage!) |
It's still used, see tests: * build_script::doctest_receives_build_link_args * build_script::rename_with_link_search_path * run::run_with_library_paths * run::library_paths_sorted_alphabetically
dwijnand
force-pushed
the
todo-remove-Compilation.native_dirs
branch
from
ab1bd24
to
b9f864e
Compare
dwijnand
changed the title
|
@bors r+ |
|
📌 Commit b9f864e has been approved by |
bors
added a commit
that referenced
this pull request
Oct 24, 2018
…=dwijnand Remove the remote TODO on Compilation.native_dirs It's still used, see tests: * build_script::doctest_receives_build_link_args * build_script::rename_with_link_search_path * run::run_with_library_paths * run::library_paths_sorted_alphabetically Originally I was trying to action #792 (comment) with this PR
dwijnand
changed the title
|
☀️ Test successful - status-appveyor, status-travis |
weihanglo
added a commit
to weihanglo/cargo
that referenced
this pull request
Mar 23, 2024
`native_dirs` is still in use. See< rust-lang#6194>
weihanglo
added a commit
to weihanglo/cargo
that referenced
this pull request
Mar 23, 2024
`native_dirs` is still in use. See <rust-lang#6194>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's still used, see tests:
Originally I was trying to action #792 (comment) with this PR