Fix the Travis CI badge #6530
Fix the Travis CI badge #6530
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
I don't think Cargo ever builds on master, so I don't think the icon will update properly. I'll r+ another PR and see what it looks like. |
|
Hmm, bors builds the commit, attaches the result to the SHA and then fast-forwards master to it (on success), so I think it should show up. It would be always green though, actually. 😄 |
|
Travis only knows about the branches it tests. As you can see, the new url doesn't work (says "unknown"): I think it will need to be auto-cargo, like this: https://travis-ci.com/rust-lang/cargo.svg?branch=auto-cargo But, yea, it should never be not-green. |
|
Yep, agreed. |
|
|
|
I wonder if we could just link to an always green badge because master is alwasy green anyway... Alternatively we could do something like run |
Only run for Rust stable and the Linux target.
|
Good idea. Pushed. It could fail, because of the flaky resolution tests, but maybe that'll drive us to fix that situation. |
Workaround for travis-ci/travis-ci#1066
|
Broken pending rust-lang/rust#57484 or nightly rollback. |
|
@bors: r+ |
|
📌 Commit 5576372 has been approved by |
Fix the Travis CI badge And with this PR trigger the first travis-ci.com build! :D
|
Looks like homu missed the notification again. |
|
☀️ Test successful - checks-travis, status-appveyor |
|
Yep, a webhook notification failed, redelivered via github interface and looks good now |
Update cargo 13 commits in 34320d212dca8cd27d06ce93c16c6151f46fcf2e..2b4a5f1f0bb6e13759e88ea9512527b0beba154f 2019-01-03 19:12:38 +0000 to 2019-01-12 04:13:12 +0000 - Add test for publish with [patch] + cleanup. (rust-lang/cargo#6544) - Fix clippy warning (rust-lang/cargo#6546) - Revert "Workaround by using yesterday's nightly" (rust-lang/cargo#6540) - Adding feature-flags to `cargo publish` and `cargo package` (rust-lang/cargo#6453) - Fix the Travis CI badge (rust-lang/cargo#6530) - Add helpful text for Windows exceptions like Unix (rust-lang/cargo#6532) - Report fix bugs to Rust instead of Cargo (rust-lang/cargo#6531) - --{example,bin,bench,test} with no argument now lists all available targets (rust-lang/cargo#6505) - Rebuild on mid build file modification (rust-lang/cargo#6484) - Derive Clone for TomlDependency (rust-lang/cargo#6527) - publish: rework the crates.io detection logic. (rust-lang/cargo#6525) - avoid duplicates in ignore files (rust-lang/cargo#6521) - Rustflags in metadata (rust-lang/cargo#6503) r? @alexcrichton
And with this PR trigger the first travis-ci.com build! :D