Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cosmetic improvements #6687

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Various cosmetic improvements #6687

merged 1 commit into from
Feb 20, 2019

Conversation

dwijnand
Copy link
Member

Resubmit of #6673 which, somehow, broke.
cc @alexreg

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@dwijnand
Copy link
Member Author

r? @dwijnand

@dwijnand
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 20, 2019

📌 Commit f7c91ba has been approved by dwijnand

@bors
Copy link
Collaborator

bors commented Feb 20, 2019

⌛ Testing commit f7c91ba with merge dc83ead...

bors added a commit that referenced this pull request Feb 20, 2019
Various cosmetic improvements

Resubmit of #6673 which, somehow, broke.
cc @alexreg
@bors
Copy link
Collaborator

bors commented Feb 20, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: dwijnand
Pushing dc83ead to master...

@alexreg
Copy link
Contributor

alexreg commented Feb 20, 2019

Sorry @dwijnand, I normally would have gotten around to this sooner, but I've been unusually busy the past couple of days. Thanks for sorting this out for me!

@dwijnand
Copy link
Member Author

Thanks. But it was no problem, just a very interesting glitch on GitHub!

@alexreg
Copy link
Contributor

alexreg commented Feb 21, 2019

@dwijnand Yeah, I've experienced it a few times... I'm not sure of the cause even. Seems non-deterministic.

bors added a commit to rust-lang/rust that referenced this pull request Feb 23, 2019
Update cargo

5 commits in b33ce7fc9092962b0657b4c25354984b5e5c47e4..5c6aa46e6f28661270979696e7b4c2f0dff8628f
2019-02-19 18:42:50 +0000 to 2019-02-22 19:32:35 +0000
- convert unused doc comments to regular comments (rust-lang/cargo#6692)
- Add more about system library on whether to keep Cargo.lock (rust-lang/cargo#6685)
- Warn when excluding non-existing packages (rust-lang/cargo#6679)
- Incremental profile cleanup. (rust-lang/cargo#6688)
- Various cosmetic improvements (rust-lang/cargo#6687)
@ehuss ehuss added this to the 1.34.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants