Fix exponentiality in depend_on_deps_of_deps. #7062
Conversation
|
r? @ehuss (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Drive by comment, should this have a test? |
|
Thanks for this! I think that TODO is actually quite old and perhaps not ready to be fully closed out, could that be backed out from this change? Otherwise this looks reasonable to me. If we can have a test that'd be great, but I'd assume that this would require a pretty large crate graph and/or this would very quickly come up when pipelining was turned on so I don't think that a test is critical. |
|
I have undone the other change, and I added a test targeting the bad behaviour. I confirmed that without my patch, the test takes a very long time (at least 60 seconds, but it should internally traverse something like 2^30 deps), but now finishes very quickly. |
|
@bors: r+ Thanks! |
|
📌 Commit 15e0802 has been approved by |
bors
added
S-waiting-on-bors
Fix exponentiality in depend_on_deps_of_deps. With `CARGO_BUILD_PIPELINING=true`, cargo was spending a long time (15 seconds) before starting any compilation. That is caused by a naive graph traversal in `depend_on_deps_of_deps`. Instead, let's make sure not to keep traversing the same deps. With this patch, things are fast again.
|
☀️ Test successful - checks-travis, status-appveyor |
Update cargo Update cargo 12 commits in 4c1fa54d10f58d69ac9ff55be68e1b1c25ecb816..677a180f4c8ca1dcef594f68dd0e63e4f08621f5 2019-06-24 11:24:18 +0000 to 2019-07-08 13:43:02 +0000 - Update dependencies (rust-lang/cargo#7106) - Fix overwriting .d file for binary with dSYM on apple targets. (rust-lang/cargo#7057) - Update changelog. (rust-lang/cargo#7102) - Revert "Fix 'getting started' internal links" (rust-lang/cargo#7099) - Bump to 0.39.0 (rust-lang/cargo#7100) - Update dependency.rs (rust-lang/cargo#7098) - Typo (rust-lang/cargo#7097) - Fix 'getting started' internal links (rust-lang/cargo#7093) - Fix misleading comment in testsuite (rust-lang/cargo#7090) - improve uncommitted changes cargo-package message (rust-lang/cargo#7083) - Clean environment when git-fetch-with-cli is used. (rust-lang/cargo#7082) - Fix exponentiality in depend_on_deps_of_deps. (rust-lang/cargo#7062)
With
CARGO_BUILD_PIPELINING=true, cargo was spending a long time (15 seconds) before starting any compilation. That is caused by a naive graph traversal independ_on_deps_of_deps. Instead, let's make sure not to keep traversing the same deps. With this patch, things are fast again.