Error out on ssh dependencies (fixes #55) #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Can you add a test for this as well? |
|
Sure, just give me a second. |
|
Actually, I just realized that this won't fail on the long form of SSH URLs. I assume I should add that as well? |
|
This is mostly just focused on making the error more user-friendly, so it's ok to just add a test case about the error being user-friendly. |
|
Okay, I've added a test. |
|
Thanks! Could you squash the commits together as well? |
|
I think it should be good now. |
bors
added a commit
that referenced
this pull request
Jun 27, 2014
Now Cargo should give a normal error message rather than a task failure when encountering an SSH URL as a dependency.
bors
added a commit
to alexcrichton/cargo
that referenced
this pull request
Sep 2, 2014
Now Cargo should give a normal error message rather than a task failure when encountering an SSH URL as a dependency.
ehuss
pushed a commit
to ehuss/cargo
that referenced
this pull request
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now Cargo should give a normal error message rather than a task failure when encountering an SSH URL as a dependency.