Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't need to copy this string #7324

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@Eh2406
Copy link
Contributor

commented Sep 3, 2019

This removes a String::clone that I noticed when profiling no-op builds of cargo, benchmarks show a barely visible improvement. Looks like it was added in #6880, but I am not sure why.

@Eh2406 Eh2406 requested a review from alexcrichton Sep 3, 2019
@rust-highfive

This comment has been minimized.

Copy link

commented Sep 3, 2019

r? @ehuss

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406 Eh2406 force-pushed the Eh2406:two-copys-of-hash branch from 4a1fca9 to 542536b Sep 4, 2019
@alexcrichton

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

📌 Commit 542536b has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

⌛️ Testing commit 542536b with merge e9fc779...

bors added a commit that referenced this pull request Sep 4, 2019
don't need to copy this string

This removes a `String::clone` that I noticed when profiling no-op builds of cargo, benchmarks show a barely visible improvement. Looks like it was added in #6880, but I am not sure why.
@bors

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing e9fc779 to master...

@bors bors merged commit 542536b into rust-lang:master Sep 4, 2019
10 checks passed
10 checks passed
homu Test successful
Details
rust-lang.cargo Build #20190904.8 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
@Eh2406 Eh2406 deleted the Eh2406:two-copys-of-hash branch Sep 4, 2019
@ehuss ehuss referenced this pull request Sep 10, 2019
bors added a commit to rust-lang/rust that referenced this pull request Sep 13, 2019
Update cargo

11 commits in fe0e5a48b75da2b405c8ce1ba2674e174ae11d5d..9655d70af8a6dddac238e3afa2fec75088c9226f
2019-09-04 00:51:27 +0000 to 2019-09-10 18:16:11 +0000
- Home docs: fix broken links, misspellings, style fixes, clarifications. (rust-lang/cargo#7348)
- add readme key to cargos manifest. (rust-lang/cargo#7347)
- Explicitly ignore some results (rust-lang/cargo#7340)
- Don't resolve std's optional dependencies (rust-lang/cargo#7337)
- Add `alloc` and `proc_macro` to libstd crates (rust-lang/cargo#7336)
- doc: capitalization change for consistency. (rust-lang/cargo#7334)
- Fix test for changes in plugin API. (rust-lang/cargo#7335)
- Fix some man pages where the files weren't rebuilt. (rust-lang/cargo#7332)
- guide: add section about the cargo home (rust-lang/cargo#7314)
- `map_dependencies` is doing a deep clone, so lets make it cheaper (rust-lang/cargo#7326)
- don't need to copy this string (rust-lang/cargo#7324)
@Eh2406 Eh2406 referenced this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.