Include the publish field in cargo-metadata output #7354
Conversation
rust-highfive
added
the
S-waiting-on-review
|
Looks good to me! @rfcbot fcp merge Could src/doc/man/cargo-metadata.adoc also be updated to document this option? |
|
Done |
|
Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
src/doc/man/cargo-metadata.adoc
Outdated
| @@ -160,6 +160,11 @@ The output has the following format: | |||
| } | |||
| } | |||
| }, | |||
| /* List of registries to which this package may be published. | |||
| This is null if not specified. */ | |||
There was a problem hiding this comment.
Can this clarify that an empty array means to not allow publishing at all?
(That is what publish = false is equivalent to.)
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
@bors: r+ |
|
📌 Commit 84d08bd has been approved by |
bors
added
S-waiting-on-bors
|
@bors: r+ |
|
💡 This pull request was already approved, no need to approve it again. |
|
📌 Commit 84d08bd has been approved by |
Include the publish field in cargo-metadata output r? @alexcrichton
|
☀️ Test successful - checks-azure |
rfcbot
added
finished-final-comment-period
r? @alexcrichton