Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate towards exclusively using serde for Config #7456

Merged
merged 20 commits into from
Oct 9, 2019

Commits on Oct 8, 2019

  1. Configuration menu
    Copy the full SHA
    022814d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0f73320 View commit details
    Browse the repository at this point in the history
  3. Refactor ConfigKey to its own file

    Also make it a little less allocation-heavy by tweaking the API to
    encourage incremental building of the key and incremental destruction as
    we walk throughout the configuration tree.
    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    c0baf84 View commit details
    Browse the repository at this point in the history
  4. Finish implementing Value, use it in helpers

    Rewrite helpers like `get_bool` to use `get::<Option<Value<bool>>>`
    instead of duplicating the logic that's already with the typed access of
    configuration. This is more along the effort to centralize all
    deserialization of configuration into typed values instead of using
    ad-hoc accessors in a number of locations.
    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    37ace88 View commit details
    Browse the repository at this point in the history
  5. Remove a usage of get_list

    This callsite doesn't need the full power of `get_list`, knowing the
    definition path of each element along the list.
    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    5bba426 View commit details
    Browse the repository at this point in the history
  6. Centralize HTTP configuration in one struct

    Gives us one nice place to access and document all HTTP-related configuration
    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    2357bb0 View commit details
    Browse the repository at this point in the history
  7. Access term config through a deserialized type

    Going through and removing users of raw `get_*` functions!
    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    cbda532 View commit details
    Browse the repository at this point in the history
  8. Consolidate net configuration into a typed structure

    Less need for `get_bool` and friends!
    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    8d65906 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a458cd8 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    09d9165 View commit details
    Browse the repository at this point in the history
  11. Consolidate build key configuration

    Add a typed structure which lists all `build` key configuration
    throughout Cargo.
    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    d7d8ca1 View commit details
    Browse the repository at this point in the history
  12. Simplify cargo-new configuration reading

    No need for lots of extra helpers/parsing when using serde!
    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    44a31d6 View commit details
    Browse the repository at this point in the history
  13. Handle rebase conflicts

    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    fe7b5fc View commit details
    Browse the repository at this point in the history
  14. Run rustfmt

    alexcrichton committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    3a6cd74 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    dab42bb View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    a0d94ff View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0a9a46e View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    2387e1a View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    e0667f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. More review comments

    alexcrichton committed Oct 9, 2019
    Configuration menu
    Copy the full SHA
    9a12e48 View commit details
    Browse the repository at this point in the history