Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "cargo login" from user input when asking for login token. #7588

Merged
merged 4 commits into from Nov 15, 2019

Conversation

@TransmissionsDev
Copy link
Contributor

TransmissionsDev commented Nov 14, 2019

Hey all!

This is my first time contributing to open source, but I realized that I could help some people out and make a quick change. 馃槃

When running cargo login, I was told to please visit https://crates.io/me and paste the API Token below. However, me on autopilot accidentally pasted the whole cargo login $APITOKEN string on the website into cargo login and it took me almost 30 minutes to figure out why I couldn't publish a package.

I thought it would be useful to automatically remove cargo login from the token, just in case someone makes the brain dead mistake like me.

Hope I can get some good feedback on this, have a great one! 鉂わ笍

@rust-highfive

This comment has been minimized.

Copy link

rust-highfive commented Nov 14, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Nov 14, 2019

Seems reasonable to me, thanks!

Could you leave a comment in the source for why this is done?

@TransmissionsDev

This comment has been minimized.

Copy link
Contributor Author

TransmissionsDev commented Nov 14, 2019

Seems reasonable to me, thanks!

Could you leave a comment in the source for why this is done?

Will do!

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Nov 15, 2019

Looks good! I think rustfmt needs to be run though.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Nov 15, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 15, 2019

馃搶 Commit 648b39e has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 15, 2019

鈱涳笍 Testing commit 648b39e with merge 4aa17ed...

bors added a commit that referenced this pull request Nov 15, 2019
Remove "cargo login" from user input when asking for login token.

Hey all!

This is my first time contributing to open source, but I realized that I could help some people out and make a quick change. 馃槃

When running cargo login, I was told to `please visit https://crates.io/me and paste the API Token below`. However, me on autopilot accidentally pasted the whole `cargo login $APITOKEN` string on the website into `cargo login` and it took me almost 30 minutes to figure out why I couldn't publish a package.

I thought it would be useful to automatically remove `cargo login` from the token, just in case someone makes the brain dead mistake like me.

Hope I can get some good feedback on this, have a great one! 鉂わ笍
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 15, 2019

鈽锔 Test successful - checks-azure
Approved by: alexcrichton
Pushing 4aa17ed to master...

@bors bors merged commit 648b39e into rust-lang:master Nov 15, 2019
11 checks passed
11 checks passed
homu Test successful
Details
rust-lang.cargo Build #20191115.2 succeeded
Details
rust-lang.cargo (Linux beta) Linux beta succeeded
Details
rust-lang.cargo (Linux nightly) Linux nightly succeeded
Details
rust-lang.cargo (Linux stable) Linux stable succeeded
Details
rust-lang.cargo (Windows x86_64-msvc) Windows x86_64-msvc succeeded
Details
rust-lang.cargo (build_std) build_std succeeded
Details
rust-lang.cargo (docs) docs succeeded
Details
rust-lang.cargo (macOS) macOS succeeded
Details
rust-lang.cargo (resolver) resolver succeeded
Details
rust-lang.cargo (rustfmt) rustfmt succeeded
Details
bors added a commit to rust-lang/rust that referenced this pull request Nov 25, 2019
Update cargo, rls, books.

## nomicon

1 commits in 58e36e0e08dec5a379ac568827c058e25990d6cd..041c46e692a2592853aeca132c8dfe8eb5a79a9e
2019-10-30 08:14:24 -0500 to 2019-11-20 16:46:45 +0100
- Update unsafe-code-guidelines link (rust-lang/nomicon#175)

## cargo

15 commits in 8280633db680dec5bfe1de25156d1a1d53e6d190..750cb1482e4d0e74822cded7ab8b3c677ed8b041
2019-11-11 23:17:05 +0000 to 2019-11-23 23:06:36 +0000
- Some random comments and docstrings. (rust-lang/cargo#7625)
- Add value OUT_DIR to build-script-executed JSON message (rust-lang/cargo#7622)
- Update documentation for custom target dependencies. (rust-lang/cargo#7623)
- Document private items for binary crates by default (rust-lang/cargo#7593)
- Extend documentation on security concerns of crate names in a registry. (rust-lang/cargo#7616)
- Stabilize install-upgrade. (rust-lang/cargo#7560)
- Turn the new lock file format on by default (rust-lang/cargo#7579)
- bump im-rc version (rust-lang/cargo#7609)
- Ignore file lock errors if unsupported, on Windows (rust-lang/cargo#7602)
- Add hack for fwdansi change. (rust-lang/cargo#7607)
- Document Cargo's JSON output. (rust-lang/cargo#7595)
- Remove "cargo login" from user input when asking for login token. (rust-lang/cargo#7588)
- Fix all Clippy suggestions (but not add it to CI 馃檭) (rust-lang/cargo#7574)
- Add kind/platform info to `cargo metadata` (rust-lang/cargo#7132)
- Update core-foundation requirement from 0.6.0 to 0.7.0 (rust-lang/cargo#7585)

## reference

2 commits in 45558c464fb458affbcdcb34323946da45c8a117..9e843aeb4df083522c7277179bbaa25d0507731c
2019-11-08 14:47:35 +0100 to 2019-11-24 17:44:04 +0100
- Minor never type additions. (rust-lang/reference#723)
- Update associated-items.md.  "it"->is (rust-lang/reference#721)

## book

3 commits in e79dd62aa63396714278d484d91d48826737f47f..81ebaa2a3f88d4d106516c489682e64cacba4f60
2019-10-30 07:33:12 -0500 to 2019-11-15 08:30:04 -0800
- small fix ch04-03 & code block typo ch07-02 (rust-lang/book#2138)
- Adapt content of Chapter 16.3 in order to be consistent with improved compiler message (rust-lang/book#1779)
- [Rust 1.35] Remove FnBox and use builtin impl FnOnce for Box<FnOnce()> instead. (rust-lang/book#1906)

## rls

3 commits in 5db91c7b94ca81eead6b25bcf6196b869a44ece0..9ec2b8cb57c87517bcb506ac302eae339ffa2025
2019-10-30 16:04:39 +0100 to 2019-11-24 23:16:11 +0100
- Fix test for latest nightly. (rust-lang/rls#1595)
- doc: contributing: Remove outdated LSP extension (rust-lang/rls#1594)
- Update cargo. (rust-lang/rls#1591)

## rust-by-example

1 commits in dcee312c66267eb5a2f6f1561354003950e29105..4835e025826729827a94fdeb7cb85fed288d08bb
2019-10-31 11:26:53 -0300 to 2019-11-14 09:20:43 -0300
- crates: fix suggested value for --crate-type flag (rust-lang/rust-by-example#1292)

## edition-guide

1 commits in f553fb26c60c4623ea88a1cfe731eafe0643ce34..6601cab4666596494a569f94aa63b7b3230e9769
2019-10-30 08:27:42 -0500 to 2019-11-22 12:08:58 -0500
- Remove final nursery reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.