Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add space to comments #8476

Merged
merged 2 commits into from
Jul 13, 2020
Merged

fix: add space to comments #8476

merged 2 commits into from
Jul 13, 2020

Conversation

Rustin170506
Copy link
Member

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 10, 2020
@ehuss
Copy link
Contributor

ehuss commented Jul 10, 2020

Thanks! Looks like some tests need to be updated?

@Rustin170506
Copy link
Member Author

Rustin170506 commented Jul 11, 2020 •
edited
Loading

Thanks! Looks like some tests need to be updated?

@ehuss Fixed it. PTAL~ Thanks!

@Rustin170506
Copy link
Member Author

@ehuss Ping~

@ehuss
Copy link
Contributor

ehuss commented Jul 13, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 13, 2020

📌 Commit 9ede526 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2020
@bors
Copy link
Collaborator

bors commented Jul 13, 2020

⌛ Testing commit 9ede526 with merge fc871c9...

bors added a commit that referenced this pull request Jul 13, 2020
@bors
Auto merge of #8476 - Rustin-Liu:rustin-patch, r=ehuss
fc871c9 
fix: add space to comments
@bors
Copy link
Collaborator

bors commented Jul 13, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 13, 2020
@ehuss
Copy link
Contributor

ehuss commented Jul 13, 2020

@bors retry

Err:34 https://storage.googleapis.com/bazel-apt stable/jdk1.8 amd64 Packages
  Writing more data than expected (28234 > 27800)

Which I think means the apt repos are out of sync.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2020
@bors
Copy link
Collaborator

bors commented Jul 13, 2020

⌛ Testing commit 9ede526 with merge 43cf773...

@bors
Copy link
Collaborator

bors commented Jul 13, 2020

☀️ Test successful - checks-azure
Approved by: ehuss
Pushing 43cf773 to master...

@bors bors merged commit 43cf773 into rust-lang:master Jul 13, 2020
@ehuss ehuss mentioned this pull request Jul 14, 2020
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 14, 2020
@Manishearth
Rollup merge of rust-lang#74332 - ehuss:update-cargo, r=ehuss
1cd8c5e 
Update cargo

4 commits in 4f74d9b2a771c58b7ef4906b2668afd075bc8081..43cf77395cad5b79887b20b7cf19d418bbd703a9
2020-07-08 17:13:00 +0000 to 2020-07-13 17:35:42 +0000
- fix: add space to comments (rust-lang/cargo#8476)
- Allow configuring unstable flags via config file (rust-lang/cargo#8393)
- Add support for rustc's `-Z terminal-width`. (rust-lang/cargo#8427)
- Avoid colliding with older Cargo fingerprint changes (rust-lang/cargo#8473)
@ehuss ehuss added this to the 1.47.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ehuss ehuss

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rustin170506 @rust-highfive @ehuss @bors