Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emphasize git dependency version locking behavior. #8561

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Emphasize git dependency version locking behavior. #8561

merged 1 commit into from
Jul 29, 2020

Conversation

icorbrey
Copy link

@icorbrey icorbrey commented Jul 29, 2020

Added a section in src/doc/src/reference/specifying-dependencies.md clarifying Cargo's version locking behavior when adding git dependencies:

Once a `git` dependency has been added, Cargo will lock that dependency to the
latest commit at the time. New commits will not be pulled down automatically
once the lock is in place. However, they can be pulled down manually with
`cargo update`.

Resolves #8555

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 29, 2020
@icorbrey
Copy link
Author

icorbrey commented Jul 29, 2020

Um... that's interesting. Why did it fail?

@ehuss
Copy link
Contributor

ehuss commented Jul 29, 2020

Thanks for the PR!

The build failure was due to some independent changes, now fixed via #8558.

@bors r+

@bors
Copy link
Collaborator

bors commented Jul 29, 2020

📌 Commit 13e789e has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 29, 2020
@bors
Copy link
Collaborator

bors commented Jul 29, 2020

⌛ Testing commit 13e789e with merge 21a1e15...

@icorbrey
Copy link
Author

Should this PR get closed or merged?

@ehuss
Copy link
Contributor

ehuss commented Jul 29, 2020

It'll get merged soon. We use a bot called bors which runs all tests before merging to master. The command I entered above told it to put in the queue of things to test. It should get merged in about 15-20 minutes, and then the bot will handle closing things.

@icorbrey
Copy link
Author

Gotcha, that's pretty cool! Thanks!

@bors
Copy link
Collaborator

bors commented Jul 29, 2020

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 21a1e15 to master...

@bors bors merged commit 21a1e15 into rust-lang:master Jul 29, 2020
@icorbrey icorbrey deleted the git-dep-lock-docs branch July 29, 2020 17:21
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2020
Update cargo

14 commits in aa6872140ab0fa10f641ab0b981d5330d419e927..974eb438da8ced6e3becda2bbf63d9b643eacdeb
2020-07-23 13:46:27 +0000 to 2020-07-29 16:15:05 +0000
- Fix O0 build scripts by default without `[profile.release]` (rust-lang/cargo#8560)
- Emphasize git dependency version locking behavior. (rust-lang/cargo#8561)
- Update lock file encodings on changes (rust-lang/cargo#8554)
- Fix sporadic lto test failures. (rust-lang/cargo#8559)
- build-std: Fix libraries paths following upstream (rust-lang/cargo#8558)
- Flag git http errors as maybe spurious (rust-lang/cargo#8553)
- Display builtin aliases with `cargo --list` (rust-lang/cargo#8542)
- Check manifest for requiring nonexistent features (rust-lang/cargo#7950)
- Clarify test name filter usage (rust-lang/cargo#8552)
- Revert Cargo Book changes for default edition (rust-lang/cargo#8551)
- Prepare for not defaulting to master branch for git deps (rust-lang/cargo#8522)
- Include `+` for crates.io feature requirements in the Cargo Book section on features (rust-lang/cargo#8547)
- Update termcolor and fwdansi versions (rust-lang/cargo#8540)
- Cargo book nitpick in Manifest section (rust-lang/cargo#8543)
@ehuss ehuss added this to the 1.47.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo git dependencies do not auto-track latest commit on branch
5 participants