Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to testsuite error output. #9589

Merged
merged 10 commits into from
Jun 17, 2021
Merged

Commits on Jun 15, 2021

  1. Remove some unused code.

    ehuss committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    2021865 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. testsuite: Support anyhow error chains in error messages.

    This is intended to help with adding more usage of anyhow in the
    testsuite, which can help show context for errors.
    
    This also includes some small improvements to the error messages to
    provide more information.
    ehuss committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    0f5deb6 View commit details
    Browse the repository at this point in the history
  2. Move comparison and diffing code to a new module.

    This includes various minor refactorings to try to clean things up
    and provide better error messages.
    ehuss committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    e132bb5 View commit details
    Browse the repository at this point in the history
  3. Remove with_either_contains.

    It isn't needed anymore, and I would prefer to not keep around unused code.
    It can always be added back if ever needed again.
    ehuss committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    6dff997 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24b8936 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b9f15ab View commit details
    Browse the repository at this point in the history
  6. Don't export lines_match.

    Use better high-level interfaces to achieve the same thing.
    ehuss committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    b73e3d4 View commit details
    Browse the repository at this point in the history
  7. Remove the double-backslash escape for matching.

    Using `with_json` is safer since it knows what JSON escaping is.
    ehuss committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    aea5ca3 View commit details
    Browse the repository at this point in the history
  8. Only normalize paths on windows.

    I don't trust that all these transformations won't have unintended
    consequences on other platforms. It is nice to verify there aren't any
    backslash shenanigans on other platforms.
    ehuss committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    205148e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    16b5402 View commit details
    Browse the repository at this point in the history