Include the linker in the fingerprint. #9647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I could swear we've talked about this, but I can't find any records or issues related to it. |
ehuss
commented
Jul 2, 2021
| @@ -812,7 +812,7 @@ impl Fingerprint { | |||
| *self.memoized_hash.lock().unwrap() = None; | |||
| } | |||
|
|
|||
| fn hash(&self) -> u64 { | |||
| fn hash_u64(&self) -> u64 { | |||
There was a problem hiding this comment.
I renamed this because there were two functions with the same name but different signatures (the inherent fn and the trait). This caused a problem when importing the trait, and was also confusing.
|
@bors: r+ |
|
📌 Commit 28c3bef has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 3, 2021
Update cargo 5 commits in 4952979031e2cf1d901c817a32e25a156a19db4c..3ebb5f15a940810f250b68821149387af583a79e 2021-07-01 01:14:50 +0000 to 2021-07-02 20:35:38 +0000 - Adjust the edition2021 resolver diff report. (rust-lang/cargo#9649) - Include the linker in the fingerprint. (rust-lang/cargo#9647) - Temporarily disable windows env test. (rust-lang/cargo#9646) - Handle git deleted files with dirty worktree. (rust-lang/cargo#9645) - Adjust error message with offline and frozen. (rust-lang/cargo#9644)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the linker from the
[target]config table to the fingerprint. Previously, changing the value would not trigger a rebuild.