Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compile_library #213

Merged
merged 2 commits into from
Jul 18, 2017
Merged

Remove compile_library #213

merged 2 commits into from
Jul 18, 2017

Conversation

ottaviohartman
Copy link
Contributor

Fixes #188.

Pretty straightforward removal. I use the syntax introduced in #205 in the README.

Let me know if it needs work!

@alexcrichton
Copy link
Member

Thanks! In terms of coordination though could this avoid deleting it just yet? Instead can this delete all references and just slap a #[deprecated] and #[doc(hidden)] on it?

When a new major release comes out I can clean out the deprecated pieces.

@ottaviohartman
Copy link
Contributor Author

Updated! Thanks Alex

@alexcrichton alexcrichton merged commit 7b6f4a0 into rust-lang:master Jul 18, 2017
@ottaviohartman ottaviohartman deleted the remove_compile_library branch July 18, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants