Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I am adding a public interface for iterating the files to be compiled.
My use case is to generate
compile_commands.json
outside. This configuration is needed by various language servers/IDEs and contains the mapping between source files and their compile commands. We can already get the compile commands usingget_compiler
, but the files are not exposed through any public interface yet.I've made this interface a little more general by not exposing
Arc<Path>
but give an iterator instead.I am also wondering if adding a
compile_commands.json
-generator directly intocc-rs
might be useful as this is a built-in feature for many build systems including cmake, bazel, makefile, ninja, and some rust ones etc. It is better if one can generate one json combined from multiplecc::Build
instances.