Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #691

Merged
merged 1 commit into from Mar 10, 2021
Merged

fix typo #691

merged 1 commit into from Mar 10, 2021

Conversation

basavesh
Copy link

A simple typo fix, found while reading the book.

Copy link
Member

@detrumi detrumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for fixing that!

@detrumi
Copy link
Member

detrumi commented Mar 10, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

📌 Commit bfee7f5 has been approved by detrumi

@basavesh
Copy link
Author

@detrumi I see similar stuff in https://rust-lang.github.io/chalk/book/types.html too. Should I create an another PR?

The AST. This is used purely for writing test cases with a Rust-like syntax. This is consumed by lowering code, which takes AST and products Rust IR (the next bullet point).
The Rust IR. This is a "HIR-like" notation that defines the interesting properties of things like traits, impls, and structs. It is an input to the rules code, which produces

@detrumi
Copy link
Member

detrumi commented Mar 10, 2021

Hm, why didn't bors merge yet?

@bors r+

Edit: Ah, now it's saying that it's blocked by another PR. But that's an old PR?

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

📌 Commit bfee7f5 has been approved by detrumi

@Mark-Simulacrum
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

@Mark-Simulacrum: 🔑 Insufficient privileges: not in try users

@jackh726
Copy link
Contributor

@bors retry

2 similar comments
@detrumi
Copy link
Member

detrumi commented Mar 10, 2021

@bors retry

@jackh726
Copy link
Contributor

@bors retry

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

⌛ Testing commit bfee7f5 with merge 92b8df3...

@bors
Copy link
Collaborator

bors commented Mar 10, 2021

☀️ Test successful - checks-actions
Approved by: detrumi
Pushing 92b8df3 to master...

@bors bors merged commit 92b8df3 into rust-lang:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants