Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modsi3: debug assertion #151

Closed
japaric opened this issue Mar 13, 2017 · 1 comment · Fixed by #152
Closed

modsi3: debug assertion #151

japaric opened this issue Mar 13, 2017 · 1 comment · Fixed by #152

Comments

@japaric
Copy link
Member

japaric commented Mar 13, 2017 

#[test]
fn modsi3() {
    let (a, b) = (-2147483648, 1798783296);
    let c_ = __modsi3(a, b);
}
running 1 test
test modsi3 ... FAILED

failures:

---- modsi3 stdout ----
        thread 'modsi3' panicked at 'attempt to subtract with overflow', /home/japaric/.cargo/git/checkouts/compiler-builtins-ec094dc45a0179c8/9681358/src/int/sdiv.rs:38
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    modsi3

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured

error: test failed
@japaric
Copy link
Member Author

japaric commented Mar 14, 2017

Similar error: moddi3 with (4173728065815314432, -9223372036854775808)

running 1 test
test moddi3 ... FAILED

failures:

---- moddi3 stdout ----
        thread 'moddi3' panicked at 'attempt to subtract with overflow', /home/japaric/.cargo/git/checkouts/compiler-builtins-ec094dc45a0179c8/9681358/src/int/sdiv.rs:36
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    moddi3

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured

japaric pushed a commit that referenced this issue Mar 14, 2017
fix debug assertion in modsi3 / moddi3
2faec6a 
fixes #151
this fix is very similar to #149
This was referenced Mar 14, 2017
Merged
Closed
bors added a commit that referenced this issue Mar 14, 2017
@bors
Auto merge of #152 - rust-lang-nursery:gh151, r=alexcrichton
505b297 
fix debug assertion in modsi3 / moddi3

fixes #151
this fix is very similar to #149

r? @alexcrichton
bors added a commit that referenced this issue Apr 7, 2017
@bors
Auto merge of #152 - rust-lang-nursery:gh151, r=alexcrichton
09145e6 
fix debug assertion in modsi3 / moddi3

fixes #151
this fix is very similar to #149

r? @alexcrichton
@bors bors closed this as completed in #152 Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix debug assertion in modsi3 / moddi3 rust-lang/compiler-builtins
1 participant
@japaric