Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on new nightly. #272

Merged
merged 1 commit into from
Jan 22, 2019

Conversation

cyplo
Copy link
Contributor

@cyplo cyplo commented Jan 20, 2019

Compilation on rustc 1.33.0-nightly (c76f3c374 2019-01-18) failed with

error: the feature `cfg_target_vendor` has been stable since 1.33.0 and no longer requires an attribute to enable
  --> src/lib.rs:19:12
   |
19 | #![feature(cfg_target_vendor)]
   |            ^^^^^^^^^^^^^^^^^
   |

Removed the attribute to make it compile.

Compilation on rustc 1.33.0-nightly (c76f3c374 2019-01-18) failed with
```
error: the feature `cfg_target_vendor` has been stable since 1.33.0 and no longer requires an attribute to enable
  --> src/lib.rs:19:12
   |
19 | #![feature(cfg_target_vendor)]
   |            ^^^^^^^^^^^^^^^^^
   |
```

Removed the attribute to make it compile.
@cyplo
Copy link
Contributor Author

cyplo commented Jan 20, 2019

It seems to fail on gnu builds on windows but not msvc ones - I can try fixing this if anyone is up to helping me here to point me to how to do it ?

@alexcrichton alexcrichton merged commit 61a3c5a into rust-lang:master Jan 22, 2019
@alexcrichton
Copy link
Member

No worries, looks good!

@cyplo cyplo deleted the fix-new-nightly branch January 23, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants