Correct SPDX identifier to "MIT OR (Apache-2.0 AND NCSA)" #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Cargo.tomlfile specifies the license asMIT/Apache-2.0. This library, however, inherited LLVM'sMIT/NCSAlicensing. LLVM has since switched toMIT OR NCSA OR (Apache-2.0 WITH LLVM-exception), so it's probably possible to re-license this crate toMIT/Apache-2.0, however, the fact is that this hasn't happened yet, since the Readme still says that contributors license their contributions underMIT/NCSA. This implies that all contributors would need to agree to license their code underApache-2.0first.This would make the license of this repo
MIT/NCSA, but the crate also directly bundleslibm, which usesMIT/Apache-2.0. Combining the two, we getMIT OR (Apache-2.0 AND NCSA).This issue is being discussed in #307. This PR implements what I believe to be the correct solution to this problem. Please exercise caution, as I am not a lawyer.