This repository has been archived by the owner on May 21, 2019. It is now read-only.
Provide lprofGetHostName for all windows environments #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function doesn't use anything MSVC specific but works fine for any _WIN32 target. Differential Revision: https://reviews.llvm.org/D58106 git-svn-id: https://llvm.org/svn/llvm-project/compiler-rt/trunk@353918 91177308-0d34-0410-b5e6-96231b3b80d8
|
Thanks, @mati865! I'm not sure what our policy regarding this fork of compiler-rt is... |
|
I'm not sure either so I pinged Alex. BTW with slight change to rust repository PGO seems to work and size of hello world example dropped from 2.4 MiB to 1.4 MiB. |
|
It's fine to patch up our forks of LLVM projects as we typically do it all the time. I've long wanted to unify this repository and the llvm-project repository, and especially if we're going to carry special patches here I think we'll instead want to use llvm-project. Can this be sent to the llvm-project repository instead? |
|
No problem for me if you plan on switching |
|
The switch has happened in rust-lang/compiler-builtins#294 |
|
Oh, nice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for PGO on
windows-gnutarget.cc @alexcrichton @michaelwoerister