Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tier-3 targets for OpenHarmony #568

Closed
1 of 3 tasks
Amanieu opened this issue Nov 11, 2022 · 3 comments
Closed
1 of 3 tasks

New tier-3 targets for OpenHarmony #568

Amanieu opened this issue Nov 11, 2022 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@Amanieu
Copy link
Member

Amanieu commented Nov 11, 2022

Proposal

This MCP proposes to add two new tier 3 targets for OpenHarmony:

  • aarch64-linux-ohos
  • arm-linux-ohos

Tier 3 target requirements

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

The target name is consistent with the one used by OpenHarmony's C toolchain.

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

OpenHarmony is BSD-licensed and uses a Clang/musl-based toolchain. There are no legal issues.

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

Work on the OpenHarmony target is sponsored by Huawei.

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

This target will fully support std.

The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Initially this target will only be used for Rust code internal to the OpenHarmony project. After initial Rust support is in place, this will later be expanded to support external Rust code for applications running on OpenHarmony.

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.

OK

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.

All OpenHarmony-specific code is under #[cfg(target_env = "ohos")].

Mentors or Reviewers

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@Amanieu Amanieu added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Nov 11, 2022
@rustbot
Copy link
Collaborator

rustbot commented Nov 11, 2022

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Nov 11, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Nov 18, 2022
@wesleywiser
Copy link
Member

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Dec 8, 2022
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Dec 22, 2022
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Jan 4, 2023
bors added a commit to rust-lang/libc that referenced this issue Mar 4, 2023
Add support for OpenHarmony

This PR adds support for [OpenHarmony](https://gitee.com/openharmony/docs/) targets:
- `aarch64-linux-ohos`
- `arm-linux-ohos`

Compiler team MCP: rust-lang/compiler-team#568

OpenHarmony uses a fork of musl with minor modifications, so most of the code is shared with other musl targets. Additionally, although OpenHarmony uses musl 1.2, it is still ABI-compatible with musl 1.1 so the existing bindings should continue to work until #3068 is merged.

A PR to add the targets to rustc will follow after this is merged.
bors added a commit to rust-lang-ci/rust that referenced this issue Mar 29, 2023
Add OpenHarmony targets

- `aarch64-unknown-linux-ohos`
- `armv7-unknown-linux-ohos`

Compiler team MCP: rust-lang/compiler-team#568
thomcc pushed a commit to tcdi/postgrestd that referenced this issue Jun 1, 2023
Add OpenHarmony targets

- `aarch64-unknown-linux-ohos`
- `armv7-unknown-linux-ohos`

Compiler team MCP: rust-lang/compiler-team#568
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 18, 2023
Add x86_64-unknown-linux-ohos target

This complements the existing `aarch64-unknown-linux-ohos` and `armv7-unknown-linux-ohos` targets.

This should be covered by the existing MCP (rust-lang/compiler-team#568), but I can also create a new MCP if that is preferred.
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Jul 18, 2023
Add x86_64-unknown-linux-ohos target

This complements the existing `aarch64-unknown-linux-ohos` and `armv7-unknown-linux-ohos` targets.

This should be covered by the existing MCP (rust-lang/compiler-team#568), but I can also create a new MCP if that is preferred.
Chilledheart added a commit to Chilledheart/socket2 that referenced this issue Jan 28, 2024
OpenHarmony(alias ohos) is tie 3 supported target for rust.
see rust-lang/compiler-team#568.

In implementation it sits close to musl instead of bionic
and napi instead jni when comparing with android.

Below is copied from ohos sdk:

```
> ag iov_max openharmony/9/native/sysroot/usr/include
openharmony/9/native/sysroot/usr/include/limits.h
50:#define IOV_MAX 1024
162:#define _XOPEN_IOV_MAX          16

openharmony/9/native/sysroot/usr/include/unistd.h
320:#define _SC_IOV_MAX 60
```
Chilledheart added a commit to Chilledheart/nix that referenced this issue Jan 28, 2024
OpenHarmony(alias ohos) is tie 3 supported target for rust.
see rust-lang/compiler-team#568.

In implementation it sits close to musl instead of bionic
and napi instead jni when comparing with android.
Thomasdezeeuw pushed a commit to rust-lang/socket2 that referenced this issue Jan 28, 2024
OpenHarmony(alias ohos) is tie 3 supported target for rust.
see rust-lang/compiler-team#568.

In implementation it sits close to musl instead of bionic
and napi instead jni when comparing with android.

Below is copied from ohos sdk:

```
> ag iov_max openharmony/9/native/sysroot/usr/include
openharmony/9/native/sysroot/usr/include/limits.h
50:#define IOV_MAX 1024
162:#define _XOPEN_IOV_MAX          16

openharmony/9/native/sysroot/usr/include/unistd.h
320:#define _SC_IOV_MAX 60
```
Chilledheart added a commit to Chilledheart/nix that referenced this issue Jan 29, 2024
OpenHarmony(alias ohos) is tie 3 supported target for rust.
see rust-lang/compiler-team#568.

In implementation it sits close to musl instead of bionic
and napi instead jni when comparing with android.

Tested with:
- cargo build --target x86_64-unknown-linux-ohos --features acct,dir,env,fs
- cargo build --target aarch64-unknown-linux-ohos --features acct,dir,env,fs
github-merge-queue bot pushed a commit to nix-rust/nix that referenced this issue Jan 30, 2024
OpenHarmony(alias ohos) is tie 3 supported target for rust.
see rust-lang/compiler-team#568.

In implementation it sits close to musl instead of bionic
and napi instead jni when comparing with android.

Tested with:
- cargo build --target x86_64-unknown-linux-ohos --features acct,dir,env,fs
- cargo build --target aarch64-unknown-linux-ohos --features acct,dir,env,fs
lnicola pushed a commit to lnicola/rust-analyzer that referenced this issue Apr 7, 2024
Add x86_64-unknown-linux-ohos target

This complements the existing `aarch64-unknown-linux-ohos` and `armv7-unknown-linux-ohos` targets.

This should be covered by the existing MCP (rust-lang/compiler-team#568), but I can also create a new MCP if that is preferred.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
Add x86_64-unknown-linux-ohos target

This complements the existing `aarch64-unknown-linux-ohos` and `armv7-unknown-linux-ohos` targets.

This should be covered by the existing MCP (rust-lang/compiler-team#568), but I can also create a new MCP if that is preferred.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants