Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uplift some -Zverbose calls and rename to -Zverbose-internals #706

Closed
1 of 3 tasks
jyn514 opened this issue Dec 19, 2023 · 3 comments
Closed
1 of 3 tasks

uplift some -Zverbose calls and rename to -Zverbose-internals #706

jyn514 opened this issue Dec 19, 2023 · 3 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 19, 2023 •
edited

Proposal

right now, --verbose has exactly one effect, which is to print more information for --version: https://github.com/rust-lang/rust/blob/558ac1cfb7c214d06ca471885a57caa6c8301bae/compiler/rustc_driver_impl/src/lib.rs#L884

this seems kind of silly. there are lots of other places where the compiler adds more info based on -Z verbose. some of these are quite useful to show in diagnostics, for example showing full types in a type error rather than eliding similar types with _. it would be nice to display those when --verbose is passed.

furthermore, it's confusing to have both --verbose and -Z verbose. i suggest renaming the internal flag (perhaps -Z verbose-internals makes it clear that it's not meant to be useful for anyone but compiler devs?).

; rg '\.verbose\(' compiler -l
compiler/rustc_driver_impl/src/pretty.rs
compiler/rustc_middle/src/mir/pretty.rs
compiler/rustc_middle/src/ty/generics.rs
compiler/rustc_middle/src/ty/print/pretty.rs
compiler/rustc_hir_typeck/src/expr.rs
compiler/rustc_infer/src/traits/structural_impls.rs
compiler/rustc_query_impl/src/plumbing.rs
compiler/rustc_infer/src/infer/error_reporting/mod.rs

Mentors or Reviewers

@compiler-errors

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
@jyn514 jyn514 added major-change A proposal to make a major change to rustc T-compiler Add this label so rfcbot knows to poll the compiler team labels Dec 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2023

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:

@rustbot concern reason-for-concern 
<description of the concern>

Concerns can be lifted with:

@rustbot resolve reason-for-concern

See documentation at https://forge.rust-lang.org

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Dec 19, 2023
@jyn514 jyn514 changed the title merge -Zverbose into --verbose uplift some -Zverbose calls and rename to -Zverbose-internals Dec 19, 2023
@estebank
Copy link

Follow @compiler-errors' guidance from the zulip thread.

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label Dec 19, 2023
This was referenced Dec 19, 2023
Merged
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Dec 26, 2023
@bors
Auto merge of rust-lang#119129 - jyn514:verbose, r=compiler-errors,es…
2fe50cd 
…tebank

rework `-Zverbose`

implements the changes described in rust-lang/compiler-team#706

the first commit is only a name change from `-Zverbose` to `-Zverbose-internals` and does not change behavior. the second commit changes diagnostics.

possible follow up work:
- `ty::pretty` could print more info with `--verbose` than it does currently. `-Z verbose-internals` shows too much info in a way that's not helpful to users. michael had ideas about this i didn't fully understand: https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408984200
- `--verbose` should imply `-Z write-long-types-to-disk=no`. the code in `ty_string_with_limit` should take `--verbose` into account (apparently this affects `Ty::sort_string`, i'm not familiar with this code). writing a file to disk should suggest passing `--verbose`.

r? `@compiler-errors` cc `@estebank`
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Dec 28, 2023
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Dec 31, 2023
@bors
Auto merge of #119129 - jyn514:verbose, r=compiler-errors,estebank
cf98a54 
rework `-Zverbose`

implements the changes described in rust-lang/compiler-team#706

the first commit is only a name change from `-Zverbose` to `-Zverbose-internals` and does not change behavior. the second commit changes diagnostics.

possible follow up work:
- `ty::pretty` could print more info with `--verbose` than it does currently. `-Z verbose-internals` shows too much info in a way that's not helpful to users. michael had ideas about this i didn't fully understand: https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408984200
- `--verbose` should imply `-Z write-long-types-to-disk=no`. the code in `ty_string_with_limit` should take `--verbose` into account (apparently this affects `Ty::sort_string`, i'm not familiar with this code). writing a file to disk should suggest passing `--verbose`.

r? `@compiler-errors` cc `@estebank`
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Feb 13, 2024
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@estebank @apiraino @jyn514 @rustbot