Skip to content

Commit

Permalink
Auto merge of #722 - saethlin:flaky-crates, r=Mark-Simulacrum
Browse files Browse the repository at this point in the history
Ignore some more crates

Adding all the spurious failures I identified in rust-lang/rust#121282 (comment)

I'm also not sure what `blacklist.md` is for, but it hasn't been updated in 6 years so I imagine it's not important.
  • Loading branch information
bors committed Mar 18, 2024
2 parents 4dbd62a + 54ffaca commit d6e458f
Show file tree
Hide file tree
Showing 19 changed files with 60 additions and 89 deletions.
16 changes: 8 additions & 8 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

59 changes: 0 additions & 59 deletions blacklist.md

This file was deleted.

39 changes: 39 additions & 0 deletions config.toml
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,24 @@ heap-vec = { skip-tests = true } # UB, sometimes segfaults
k2_tree = { skip-tests = true } # UB, sometimes segfaults
stabby-macros = { skip = true } # broken rustc version parsing
stabby = { skip = true } # broken rustc version parsing
knetrs = { skip-tests = true } # UB
yices2 = { skip = true } # Sometimes times out, sometimes doesn't
scheduled-executor = { skip-tests = true } # UB, allocator corruption
skippy-rs = { skip-tests = true } # UB, out-of-bounds get_unchecked
pepe-telemetry = { skip-test = true } # flaky test (concurrency)
puid = { skip-tests = true } # flaky test (timing)
watchable = { skip-tests = true } # flaky test (timing)
lispi = { skip-tests = true } # flaky test (data races)
cargo-ramdisk = { skip-tests = true } # flaky test (concurrency)
njord = { skip-tests = true } # flaky test
matecito = { skip-tests = true } # flaky test (timing)
namaste = { skip-tests = true} # flaky test
faktory = { skip-tests = true } # UB via atomic-option
gazebo = { skip-tests = true } # UB but only in the test suite
context_bind = { skip-tests = true } # UB
unbounded-spsc = { skip-tests = true } # UB
vtable_gen = { skip-tests = true } # UB
crt0stack = { skip-tests = true } # UB

[github-repos]
# "org_name/repo_name" = { option = true }
Expand Down Expand Up @@ -175,5 +193,26 @@ stabby = { skip = true } # broken rustc version parsing
"mistrpopo/MandelbrotAnimation" = { skip-tests = true } # second build seems to always fail
"bastibl/futuresdr" = { skip = true } # unstable features
"FutureSDR/FutureSDR" = { skip = true } # unstable features
"yamgent/rusty-jam-2-dog-chicken" = { skip-tests = true } # UB
"Liorst4/liorforth" = { skip-tests = true } # UB
"perlindgren/fastmem" = { skip-tests = true } # UB
"aharisu/navi" = { skip-tests = true } # UB, allocator corruption
"fkjogu/stochasticsampling" = { skip-tests = true } # UB, allocator corruption
"senrust/toy_compiler2" = { skip-tests = true } # UB when tests run concurrently
"Yogaflre/leetcode" = { skip-tests = true } # UB
"UndeadRat22/kzg10-rust" = { skip-tests = true } # Wraps a non-thread-safe C++ library
"JakeDawkins/graphql-client-302-repro" = { skip-tests = true } # Stack overflow in a proc macro
"cdstanford/hydroflow-hackathon" = { skip-tests = true } # UB in a proc macro
"hydro-project/compute-pi" = { skip-tests = true } # UB in a proc macro
"KatsukiFujimoto/git-rs" = { skip-tests = true } # flaky test (HashSet iteration)
"MarkChuCarroll/schism" = { skip-tests = true } # flaky test (concurrency)
"Osrepnay/algae" = { skip-tests = true } # flaky test (timing)
"Yichangcs/Ruscheme" = { skip-tests = true } # flaky test (concurrency)
"bakaq/rust-blackhole" = { skip-tests = true } # flaky test (rng)
"diegoasanch/advent-of-code-2023" = { skip-tests = true } # flaky test (HashMap iteration)
"grnmeira/Snake" = { skip-tests = true } # flaky test (rng)
"wojciechkepka/pkger" = { skip-tests = true } # flaky test (concurrency)
"xffxff/muzero-rs" = { skip-tests = true } # flaky test (rng)
"maxjeffos/rs_dynamic_args" = { skip-tests = true } # flaky test (concurrency)

[local-crates]
1 change: 0 additions & 1 deletion src/agent/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ use crate::utils::disk_usage::DiskUsage;
use failure::Error;
use rustwide::Workspace;
use std::collections::BTreeSet;
use std::iter::FromIterator;
use std::ops;
use std::sync::atomic::{AtomicBool, Ordering};
use std::thread;
Expand Down
2 changes: 1 addition & 1 deletion src/assets.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::prelude::*;
use mime::{self, Mime};
use mime::Mime;
use serde::Serialize;
use std::borrow::Cow;
use std::collections::HashMap;
Expand Down
2 changes: 1 addition & 1 deletion src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ use std::time::Duration;
pub struct Ex(String);

#[derive(Debug, Clone)]
pub struct DockerEnv(String);
pub struct DockerEnv(#[allow(unused)] String);
impl FromStr for Ex {
type Err = Error;

Expand Down
1 change: 0 additions & 1 deletion src/crates/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ use crate::prelude::*;
use cargo_metadata::PackageId;
use percent_encoding::{percent_decode_str, utf8_percent_encode, NON_ALPHANUMERIC};
use rustwide::Crate as RustwideCrate;
use std::convert::TryFrom;
use std::fmt;
use std::path::Path;
use std::str::FromStr;
Expand Down
7 changes: 2 additions & 5 deletions src/db/migrations.rs
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
use crate::prelude::*;
use rand::{
self,
distributions::{Alphanumeric, DistString},
};
use rand::distributions::{Alphanumeric, DistString};
use rusqlite::{Connection, Transaction};
use std::collections::HashSet;

Expand Down Expand Up @@ -388,7 +385,7 @@ pub fn execute(db: &mut Connection) -> Fallible<()> {
};

for &(name, ref migration) in &migrations() {
if !executed_migrations.contains(&name.to_string()) {
if !executed_migrations.contains(name) {
let t = db.transaction()?;
match migration {
MigrationKind::SQL(sql) => t.execute_batch(sql),
Expand Down
3 changes: 1 addition & 2 deletions src/report/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,11 @@ use crate::results::{EncodedLog, EncodingType, FailureReason, ReadResults, TestR
use crate::toolchain::Toolchain;
use crate::utils;
use crates_index::GitIndex;
use mime::{self, Mime};
use mime::Mime;
use percent_encoding::{utf8_percent_encode, AsciiSet};
use std::borrow::Cow;
#[cfg(test)]
use std::collections::HashMap;
use std::convert::AsRef;
use std::fmt::{self, Display};
use std::fs;
use std::path::{Path, PathBuf};
Expand Down
1 change: 0 additions & 1 deletion src/runner/test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ use rustwide::cmd::{CommandError, ProcessLinesActions, SandboxBuilder};
use rustwide::logging::LogStorage;
use rustwide::{Build, PrepareError};
use std::collections::{BTreeSet, HashMap, HashSet};
use std::convert::TryFrom;

fn failure_reason(err: &Error) -> FailureReason {
for cause in err.iter_chain() {
Expand Down
2 changes: 1 addition & 1 deletion src/server/auth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use regex::Regex;
use rust_team_data::v1 as team_data;
use std::collections::{HashMap, HashSet};
use std::sync::{Arc, RwLock};
use warp::{self, Filter, Rejection};
use warp::{Filter, Rejection};

lazy_static! {
static ref GIT_REVISION_RE: Regex =
Expand Down
4 changes: 2 additions & 2 deletions src/server/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ use crate::server::agents::Agents;
use crate::server::auth::ACL;
use crate::server::github::{GitHub, GitHubApi};
use crate::server::tokens::{BotTokens, Tokens};
use http::{self, header::HeaderValue, Response};
use http::{header::HeaderValue, Response};
use hyper::Body;
use metrics::Metrics;
use std::net::SocketAddr;
use std::sync::{Arc, Mutex};
use warp::{self, Filter};
use warp::Filter;

lazy_static! {
static ref SERVER_HEADER: String =
Expand Down
2 changes: 1 addition & 1 deletion src/server/routes/agent.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use hyper::Body;
use std::collections::HashMap;
use std::sync::{Arc, Condvar, Mutex};
use std::time::Instant;
use warp::{self, Filter, Rejection};
use warp::{Filter, Rejection};

#[derive(Deserialize)]
#[serde(rename_all = "kebab-case")]
Expand Down
2 changes: 1 addition & 1 deletion src/server/routes/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ use http::{Response, StatusCode};
use hyper::Body;
use prometheus::{Encoder, TextEncoder};
use std::sync::Arc;
use warp::{self, Filter, Rejection};
use warp::{Filter, Rejection};

pub fn routes(
data: Arc<Data>,
Expand Down
2 changes: 1 addition & 1 deletion src/server/routes/ui/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ use http::{Response, StatusCode};
use hyper::Body;
use serde::Serialize;
use std::sync::Arc;
use warp::{self, Filter, Rejection};
use warp::{Filter, Rejection};

mod agents;
mod experiments;
Expand Down
1 change: 0 additions & 1 deletion src/server/routes/webhooks/args.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use crate::experiments::{Assignee, CapLints, DeferredCrateSelect, Mode};
use crate::toolchain::Toolchain;
use failure::{self, Fallible};

#[derive(Debug, thiserror::Error)]
#[cfg_attr(test, derive(PartialEq, Eq))]
Expand Down
2 changes: 1 addition & 1 deletion src/server/routes/webhooks/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use http::{HeaderMap, Response, StatusCode};
use hyper::Body;
use std::str::FromStr;
use std::sync::Arc;
use warp::{self, Filter, Rejection};
use warp::{Filter, Rejection};

fn process_webhook(
payload: &[u8],
Expand Down
2 changes: 1 addition & 1 deletion src/utils/mod.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
use crate::prelude::*;
use failure::{AsFail, Backtrace, Fail};
use failure::{AsFail, Backtrace};
use percent_encoding::{AsciiSet, CONTROLS};
use std::any::Any;
use std::fmt;
Expand Down
1 change: 0 additions & 1 deletion src/utils/serialize.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
use serde::ser::{Serialize, SerializeSeq, Serializer};
use std::iter::IntoIterator;

pub fn to_vec<S, T>(data: T, serializer: S) -> Result<S::Ok, S::Error>
where
Expand Down

0 comments on commit d6e458f

Please sign in to comment.