Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore rust-toolchain file in crates building in sandboxed env #560

Closed
yaahc opened this issue Jan 27, 2021 · 3 comments
Closed

ignore rust-toolchain file in crates building in sandboxed env #560

yaahc opened this issue Jan 27, 2021 · 3 comments

Comments

@yaahc
Copy link
Member

yaahc commented Jan 27, 2021 •
edited
Loading

From a comment in rust-lang/rust#75180 about a regression not being caught in artichoke by crater.

@yaahc @Dylan-DPC I pulled the rustops/crates-build-env container and Artichoke builds successfully in it, but I did notice that the rustup-installed cargo initiated an install of the toolchain specified in Artichoke's rust-toolchain file. I'm guessing this type of network activity is what the crater sandbox prevents.

Given that crater's intent is to build projects with specific versions of rustc, I think it makes sense to ignore rust-toolchain files in the repository if they are present.

Originally posted by @lopopolo in rust-lang/rust#75180 (comment)
@yaahc yaahc changed the title ignore rust-toolchain file ignore rust-toolchain file in crates building in sandboxed env Jan 27, 2021
@pietroalbini
Copy link
Member

Looking into this. It might actually be the cause of all those "error"s.

@pietroalbini pietroalbini mentioned this issue Jan 28, 2021
Merged
bors added a commit that referenced this issue Jan 28, 2021
@bors
Auto merge of #561 - pietroalbini:missing-deps, r=pietroalbini
29fcb56 
Bump rustwide and handle missing deps

This bumps rustwide to version 0.12.0, bringing a couple improvements:

* Path dependencies are no longer removed, fixing #560
* Missing dependencies are now handled instead of returning an error
@pietroalbini
Copy link
Member

Ok, opened #561 with a fix (bringing in rust-lang/rustwide#52).

Turns out the error was not rust-toolchain, as Rustwide bypasses that already (the file does not matter when you call cargo +toolchain). The problem was rustwide removing all path dependencies from the Cargo.toml, thus breaking the build.

@pietroalbini
Copy link
Member

This should be fixed now!

@SNCPlay42 SNCPlay42 mentioned this issue Mar 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaahc @pietroalbini