Fix stall on failure to mark as failed #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a task fails to get marked as failed (for whatever reason), we still want to delete it from the task graph. Otherwise it'll get left in the task graph and we'll eventually block on its completion (it's marked as running).
This should help debug early exits, by giving a clear indication of when a worker bails out. This should normally never happen; anytime it does also decreases our parallelism (as we don't respawn the worker), so should be tracked and avoided.
|
@bors r+ |
|
📌 Commit 580db9b has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of this bug hasn't yet been tracked down, but the additional logging added in the first and second commits should help track it down in the future as well. It seems pretty likely that there are more cases where bailing early leads to problems (as deletion from the graph is extremely necessary but seems easily missed), but hopefully the added logging will help reduce debugging time in the future. A more exhaustive fix here seems difficult with the current abstractions in the code, so would need more thought - my hope is that the bugs we may have can be squashed out pretty quickly with how many runs we have regularly through crater, and ultimately the rewrite avoided (as it has its own likelihood of adding bugs).